[SYCL][Joint Matrix][E2E] Auto-detect Joint Matrix features in LIT #15408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Remove dependency of Matrix tests on LIT's params like `gpu-intel-pvc=True`, `matrix=1`, etc. intel/llvm mostly got rid of parameters like that with auto-detection of architecture and usage of aspects. It would be more maintainable and less error-prone if all of features could be auto-detected.
YuriPlyakhin
force-pushed
the
jm_remove_lit_features
branch
from
668be77
to
fae9196
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
requested review from
cperkinsintel,
aelovikov-intel and
uditagarwal97
aelovikov-intel
approved these changes
Sep 17, 2024
dkhaldi
reviewed
Sep 17, 2024
sycl/test-e2e/Matrix/SPVCooperativeMatrix/SG32/element_wise_all_sizes.cpp
Show resolved
Hide resolved
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 17, 2024
|
@intel/llvm-gatekeepers , all ✅, please, merge |
|
@YuriPlyakhin Seeing these XPASSes on Arc, is it related to this change? https://github.com/intel/llvm/actions/runs/10926796671/job/30331956825 |
@sarnex , yes, pre-checkin did not catch it, because tests marked by xfail don't run there (as 2 backends are used at the same time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving maintainability:
gpu-intel-pvc=True,matrix=1,matrix-tf32=1,matrix-fp16=1.matrix,matrix-xmx8,matrix-tf32,matrix-fp16as not usedigc-devparameter, in case it is passed in the command line.REQUIRESandXFAILdirectives