-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Don't add include/sycl/
to the system includes path
#15437
base: sycl
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esimd changes lgtm, will let others review the overall change
Driver changes look fine - seeing the number of header inclusion changes we have had to make internally - how do we minimize impact on users? |
Thanks for fixing this long-standing issue!
The spec says that
It doesn't require implementation to put it into
What is your concern about the |
Yeah, I wasn't precise in what I said. What I meant is that |
It feels awkward to me that our implementation detail is located in OpenCL-specific folder. It might better be suited for |
My personal opinion: we don't - it was a bug and now it's fixed. |
Agree. SYCL-1.2.1 implementation put all headers into |
Good! I'll address it separately after this PR is merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYCL RT changes LGTM
@@ -37,7 +37,7 @@ | |||
#include <sycl/property_list.hpp> // for property_list | |||
#include <sycl/range.hpp> // for range | |||
#include <sycl/sampler.hpp> // for addressing_mode | |||
#include <ur_api.h> // for UR_RESULT_ERRO... | |||
#include <sycl/ur_api.h> // for UR_RESULT_ERRO... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes me think that ur_api.h
is our own header, but that's not true. I wonder if we need to put it into some _deps
subfolder for clarity.
Fixes #6770
Open question: I'm not sure if https://github.com/intel/llvm/tree/sycl/sycl/include/CL/__spirv should go into
include/CL/__spirv
or somewhere else. On the other hand, https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl.hpp has to be installed intoinclude/CL/sycl.hpp
per the specification.