Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Refactor OpenCL kernel generation #227

Merged
merged 7 commits into from
Jun 20, 2019

Conversation

Fznamznon
Copy link
Contributor

No description provided.

@Fznamznon Fznamznon requested a review from bader June 18, 2019 11:54
@Fznamznon Fznamznon added the upstream This change is related to upstreaming SYCL support to llorg. label Jun 18, 2019
bader
bader previously approved these changes Jun 18, 2019
We use this ThreeTransform to change only one object to another. No need to
use DenseMap here, std::pair is enough.

Signed-off-by: Mariya Podchishchaeva <[email protected]>
Signed-off-by: Mariya Podchishchaeva <[email protected]>
Signed-off-by: Mariya Podchishchaeva <[email protected]>
bader
bader previously approved these changes Jun 19, 2019
@bader bader self-assigned this Jun 19, 2019
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks simpler.
I really appreciate the comments! :-)

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
Signed-off-by: Mariya Podchishchaeva <[email protected]>
clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved
@bader bader merged commit fa4ba4c into intel:sycl Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This change is related to upstreaming SYCL support to llorg.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants