Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gentoo_build #1690

Closed
wants to merge 1 commit into from
Closed

Gentoo_build #1690

wants to merge 1 commit into from

Conversation

wennibao
Copy link
Contributor

@wennibao wennibao commented Jun 30, 2023 •
edited
Loading

gentoo musl build failed with include execinfo.h

@mattst88
Copy link
Contributor

Is this somehow related to https://bugs.gentoo.org/895816 and #1470 ?

@wennibao wennibao force-pushed the gentoo_failure branch 2 times, most recently from b73e10e to 54e8b6e Compare July 3, 2023 10:14
@wennibao
Copy link
Contributor Author

wennibao commented Jul 3, 2023

Is this somehow related to https://bugs.gentoo.org/895816 and #1470 ?

@wennibao wennibao closed this Jul 3, 2023
@wennibao wennibao reopened this Jul 3, 2023
@wennibao
Copy link
Contributor Author

wennibao commented Jul 3, 2023

Is this somehow related to https://bugs.gentoo.org/895816 and #1470 ?

Yes. It seems a same issue.

@wennibao wennibao marked this pull request as ready for review July 3, 2023 10:27
@wennibao wennibao mentioned this pull request Jul 4, 2023
Closed
@MicroYY
Copy link
Contributor

MicroYY commented Jul 5, 2023

Is this somehow related to https://bugs.gentoo.org/895816 and #1470 ?

One more same issue: #1652
Hi @mattst88 We are not sure if this is the proper fix as we don't have the Gentoo env. Will you kindly help try this PR?

@mattst88
Copy link
Contributor

Sure, I'll check.

@mattst88
Copy link
Contributor

The build on Gentoo/musl works even without this patch. CMake correctly determines that backtrace is not available:

-- Looking for backtrace
-- Looking for backtrace - not found
-- Could NOT find Backtrace (missing: Backtrace_LIBRARY Backtrace_INCLUDE_DIR)

This patch might fix a build failure when using a separate library that provides backtrace, but I'm not able to test that.

@wennibao wennibao closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicroYY MicroYY Awaiting requested review from MicroYY

@XinfengZhang XinfengZhang Awaiting requested review from XinfengZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wennibao @mattst88 @MicroYY