Add Core functions for devices, properties, version #114
Conversation
Co-authored-by: Bradley Odell <[email protected]>
crates/openvino/src/core.rs
Outdated
| /// Gets device plugins version information. | ||
| /// Device name can be complex and identify multiple devices at once like `HETERO:CPU,GPU`; | ||
| /// in this case, the returned map contains multiple entries, each per device. | ||
| pub fn versions(&self, device_name: impl AsRef<str>) -> Result<HashMap<DeviceType, Version>> { |
There was a problem hiding this comment.
Let's just return a Result<Vec<(DeviceType, Version)>>; if users really need a map there are conversion functions for that. And they might want some other collection besides a hash map so let's let give them the most simple data structure.
crates/openvino/src/core.rs
Outdated
|
|
||
| /// Gets properties related to this Core. | ||
| /// The method extracts information that can be set via the [set_property] method. | ||
| pub fn property(&self, key: PropertyKey) -> Result<Cow<str>> { |
There was a problem hiding this comment.
Maybe get_property for consistency?
crates/openvino/src/core.rs
Outdated
|
|
||
| /// Gets properties related to device behaviour. | ||
| /// The method extracts information that can be set via the [set_device_property] method. | ||
| pub fn device_property( |
There was a problem hiding this comment.
| pub fn device_property( | |
| pub fn get_device_property( |
?
crates/openvino/src/core.rs
Outdated
| &self, | ||
| device_name: impl AsRef<str>, | ||
| key: PropertyKey, | ||
| ) -> Result<Cow<str>> { |
There was a problem hiding this comment.
Hm, I'm not sure about this Cow... You're trying to avoid a copy?
There was a problem hiding this comment.
I have removed the Cow from return. I was using to_string_lossy which returned Cow<str>, handling non-utf8 and utf-8 cases both, so returning Cow would save copy for valid utf8.
I changed that now to to_str.
crates/openvino/src/core.rs
Outdated
| /// Sets a property for a device. | ||
| pub fn set_device_property( | ||
| &mut self, | ||
| device_name: impl AsRef<str>, |
There was a problem hiding this comment.
Why the AsRef here but not for value? Just a consistency nit, but it may be worthwhile to think through why we would use the trait versus the simpler &str. Either is fine though I try to bias towards simpler.
There was a problem hiding this comment.
Done, I removed AsRefs
| } | ||
|
|
||
| /// Sets properties for a device. | ||
| pub fn set_device_properties<'a>( |
There was a problem hiding this comment.
Yes I get an error otherwise, anonymous lifetimes in impl Trait are unstable
Add functions to core related to devices and properties.