This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Simplify Xml handling #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clero
force-pushed
the
remove_manual_xml_include
branch
from
7742656
to
6423d40
Compare
|
Coverage decrease for XmlFileDocSource.cpp and XmlDocSource.cpp is due to CXmlFileIncluderElement removal, but is not dead code. Call to that code may be trigged in ParameterMgr, line 715. |
clero
force-pushed
the
remove_manual_xml_include
branch
from
d4da654
to
d30488a
Compare
clero
force-pushed
the
remove_manual_xml_include
branch
2 times, most recently
from
481ce2b
to
1d4a7de
Compare
clero
force-pushed
the
remove_manual_xml_include
branch
from
ec67345
to
2c635ab
Compare
clero
force-pushed
the
remove_manual_xml_include
branch
4 times, most recently
from
cd7b241
to
7441431
Compare
clero
force-pushed
the
remove_manual_xml_include
branch
3 times, most recently
from
17920d8
to
d70c97e
Compare
SubsystemInclude is correspond to an XInclude. This patch removes this tag handling and replaces it by the standard xml inclusion tag. Signed-off-by: Jules Clero <[email protected]>
Latest patch removes SubsystemInclude tag support. It leads to some dead code. This patch removes code which was providing the Folder of the xml file to include which is now dead. Signed-off-by: Jules Clero <[email protected]>
clero
force-pushed
the
remove_manual_xml_include
branch
4 times, most recently
from
2ce3b62
to
87931fe
Compare
Signed-off-by: Jules Clero <[email protected]>
getAttribute API forces the user to call a specific API for each call getAttributeString etc.. This patch replaces this API by a template one. The success of of the action can now be checked. It can be useful one to check that a conversion succeed. Signed-off-by: Jules Clero <[email protected]>
XML exportation does not validate generated file even if a schema is provided. This patch enables the validation of the file at the end of the export. Moreover, the generated XML is checked against its schema if one is provided. Signed-off-by: Jules Clero <[email protected]>
clero
force-pushed
the
remove_manual_xml_include
branch
from
87931fe
to
eaa0f13
Compare
clero
force-pushed
the
remove_manual_xml_include
branch
from
eaa0f13
to
3a39ef3
Compare
Current serialization implementation require to map the design to the desired xml files. Thus, xml can't be easily removed and the code is hard to test. This patch introduces a serializer, based on the current xmlSerializer library. This serializer uses an Xml bindings structure which describe the mapping of the data holder to the desired xml files. Signed-off-by: Jules Clero <[email protected]>
Current configuration design is mapping classes on xml node. It leads to some empty classes which contains a node information. It also leads to inconsistent information retrieval method. Some can be retrieved through simple getters and some others are retrieved through child mechanism inherited from Element. This patch introduces a real configuration object which is a simple struct. Information retrieval is handled through xml bindings. Signed-off-by: Jules Clero <[email protected]>
isParsable is never used and the check made through it can easily be replaced by testing the return value of getDoc against NULL. Signed-off-by: Jules Clero <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to simplify xml handling.
Some base patch could be merged in an other pull request.
Coverage decreased (-0.21%) to 69.79% when pulling 2c635ab on clero:remove_manual_xml_include into 391d970 on 01org:next.