This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
packaging: define installation components #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two ways of propagating the post-install include requirements: either by adding an 'INCLUDES DESTINATION' argument to the 'install' directive or by adding an 'INTERFACE' argument to the 'target_include_directories' and using a generator expression to make it active at install-time only. This patch prefers changes for the latter since it is consistent with how build-time requirements are propagated. Signed-off-by: David Wagner <[email protected]>
Signed-off-by: David Wagner <[email protected]>
Current coverage is 80.35%@@ master #367 diff @@
========================================
Files 211 211
Lines 7169 7169
Methods 0 0
Branches 0 0
========================================
Hits 5760 5760
Misses 1409 1409
Partials 0 0
|
| # Check that all installed files are in a component (no "unspecified | ||
| # component" archive created) | ||
| - (cd build && cpack -G TGZ -D CPACK_ARCHIVE_COMPONENT_INSTALL=ON && | ||
| [ ! -x '*-Unspecified.tar.gz' ]) |
There was a problem hiding this comment.
I think you want to use -a instead of -x
$ help test
-a FILE True if file exists.
...
-x FILE True if the file is executable by you.
...
There was a problem hiding this comment.
oops, you're right. I changed my mind halfway through...
'install' commands can receive 'COMPONENT' arguments (one per target file
kind). Upon request, CMake can install only the files associated to a given
component. This will be used to generate separate archives/pacakges/installers
with CPack.
The following components are declared:
- runtime (libparameter and libremote-processor);
- dev (everything necessary to develop a plugin or a client: headers, cmake
package files, ...);
- c (the C bindings, i.e. libcparameter);
- cdev (everything necessary to develop a client using the C bindings);
- python (the Python bindings);
- eng (the various tools, XML schemas, ...);
- runtime-deps (on windows only: the msvc redistributable files).
Unfortunately, per-component debian package generation and automatic dependency
discovery (using shlibdeps) do not work together before CMake 3.4. Also,
per-component debian package dependency declaration has been added in CMake
3.4, so it is not possible yet to declare, for instance, that the 'dev' package
depends on the 'runtime' package.
However, the following works and generates one archive for each component:
cpack -G TGZ -D CPACK_ARCHIVE_COMPONENT_INSTALL=ON
Signed-off-by: David Wagner <[email protected]>
dawagner
force-pushed
the
cpack-components
branch
from
22ccc36
to
bf2c083
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following components are declared:
package files, ...);
Then, CPack can be used to generate separate packages.
@@ master #367 diff @@ ======================================== Files 211 211 Lines 7169 7169 Methods 0 0 Branches 0 0 ======================================== Hits 5760 5760 Misses 1409 1409 Partials 0 0-ainstead of-x