This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Let a domain decide when he should be synchronized. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clero
force-pushed
the
sequence_aware_sync
branch
2 times, most recently
from
0cec4dc
to
c64ab9d
Compare
Domains are browsed twice when applying configurations. The first one gather syncer of domains which are not "sequence aware" and launch a sync on them. The second one launch an apply without providing a syncer set. It lets sequence aware domains to synchronize if needed. This patch allows to browse domains only once. If a domain is sequence aware, it will be synchronized during configurations restauration. If not, the synchronisation will be delayed at the end of all applies. Sequence aware domains are now synchronized first. Signed-off-by: Jules Clero <[email protected]>
_pLastAppliedConfiguration != NULL is tested twice as we know that pApplicableDomainConfiguration is not null. This patch avoids this double test and merge the two conditions. Signed-off-by: Jules Clero <[email protected]>
clero
force-pushed
the
sequence_aware_sync
branch
from
c64ab9d
to
ac259c3
Compare
|
👍 |
|
👎 Synchronization of all sequence unaware domains needs to say coalesced. This is because the synchronization of sequence aware domains is susceptible to do some read/modify/write operations on syncers which are shared with sequence unaware ones. By synchronizing sequcence unware ones first, we ensure a proper initialization of the shared syncers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domains are browsed twice when applying configurations.
The first one gather syncer of domains which are not
"sequence aware" and launch a sync on them.
The second one launch an apply without providing a syncer set.
It lets sequence aware domains to synchronize if needed.
This patch allows to browse domains only once. If a domain
is sequence aware, it will be synchronized during configurations
restauration. If not, the synchronisation will be delayed at
the end of all applies.
Sequence aware domains are now synchronized first.
Signed-off-by: Jules Clero [email protected]
