This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
jerry.cmake: Disable LTO for JerryScript build #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With LTO compiling enabled, and Zephyr SDK 0.10.0, during final Zephyr link (which isn't done with LTO option), for armv7m targets, weird errors are thrown: zephyr-sdk-0.10.0/arm-zephyr-eabi/.../arm-zephyr-eabi/bin/ld: error: zephyr_prebuilt.elf uses VFP register arguments, /tmp/ccTrD4ap.ltrans1.ltrans.o does not Note that both JerryScript and Zephyr seem to be built with correct and consistent target options, which enable VFP usage. Disabling LTO option for JerryScript build fixes this issue. Signed-off-by: Paul Sokolovsky <[email protected]>
pfalcon
force-pushed
the
jerryscript-no-lto
branch
from
7b75a4f
to
53892f8
Compare
|
This is follow up to #1900 . I split this into separate PR because I only can explain the need for this patch with LTO bugs as presented in Zephyr SDK 0.10.0 toolchain. (I'd say, there's industrial folklore that LTO can break with non-trivial projects in rather unobvious, hard to debug ways. I personally avoid using, despite being an optimization geek.) Again, split from the main patch to see if other folks may have better ideas. |
|
+1, I ran into the same problem, so yeah, thanks for fixing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With LTO compiling enabled, and Zephyr SDk 0.10.0, during final Zephyr
link (which isn't done with LTO option), for armv7m targets, weird
errors are thrown:
zephyr-sdk-0.10.0/arm-zephyr-eabi/.../arm-zephyr-eabi/bin/ld: error:
zephyr_prebuilt.elf uses VFP register arguments, /tmp/ccTrD4ap.ltrans1.ltrans.o does not
Note that both JerryScript and Zephyr seem to be built with correct and
consistent target options, which enable VFP usage.
Disabling LTO option for JerryScript build fixes this issue.
Signed-off-by: Paul Sokolovsky [email protected]