refactor: Removes the deprecated DASHBOARD_FILTERS_EXPERIMENTAL featu…

…re flag (apache#26330)

RESOURCES/FEATURE_FLAGS.md

@@ -84,7 +84,6 @@ These features flags currently default to True and **will be removed in a future
 [//]: # "PLEASE KEEP THE LIST SORTED ALPHABETICALLY"
 
 - DASHBOARD_CROSS_FILTERS
-- DASHBOARD_FILTERS_EXPERIMENTAL
 - DASHBOARD_NATIVE_FILTERS
 - ENABLE_JAVASCRIPT_CONTROLS
 - GENERIC_CHART_AXES

UPDATING.md

@@ -30,6 +30,7 @@ assists people when migrating to a new version.
 
 ### Breaking Changes
 
+- [26330](https://github.com/apache/superset/issues/26330): Removes the deprecated `DASHBOARD_FILTERS_EXPERIMENTAL` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
 - [26344](https://github.com/apache/superset/issues/26344): Removes the deprecated `ENABLE_EXPLORE_JSON_CSRF_PROTECTION` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
 - [26345](https://github.com/apache/superset/issues/26345): Removes the deprecated `ENABLE_TEMPLATE_REMOVE_FILTERS` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled.
 - [26346](https://github.com/apache/superset/issues/26346): Removes the deprecated `REMOVE_SLICE_LEVEL_LABEL_COLORS` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.

superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts

@@ -29,7 +29,6 @@ export enum FeatureFlag {
   CONFIRM_DASHBOARD_DIFF = 'CONFIRM_DASHBOARD_DIFF',
   /** @deprecated */
   DASHBOARD_CROSS_FILTERS = 'DASHBOARD_CROSS_FILTERS',
-  DASHBOARD_FILTERS_EXPERIMENTAL = 'DASHBOARD_FILTERS_EXPERIMENTAL',
   DASHBOARD_NATIVE_FILTERS = 'DASHBOARD_NATIVE_FILTERS',
   DASHBOARD_VIRTUALIZATION = 'DASHBOARD_VIRTUALIZATION',
   DASHBOARD_RBAC = 'DASHBOARD_RBAC',

superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts

@@ -94,10 +94,7 @@ describe('nativeFilterGate', () => {
       isFeatureEnabledMock = jest
         .spyOn(uiCore, 'isFeatureEnabled')
         .mockImplementation((featureFlag: FeatureFlag) =>
-          [
-            FeatureFlag.DASHBOARD_CROSS_FILTERS,
-            FeatureFlag.DASHBOARD_FILTERS_EXPERIMENTAL,
-          ].includes(featureFlag),
+          [FeatureFlag.DASHBOARD_CROSS_FILTERS].includes(featureFlag),
         );
     });
 

superset-frontend/src/dashboard/components/nativeFilters/utils.ts

@@ -151,8 +151,7 @@ export function getExtraFormData(
 export function nativeFilterGate(behaviors: Behavior[]): boolean {
   return (
     !behaviors.includes(Behavior.NATIVE_FILTER) ||
-    (isFeatureEnabled(FeatureFlag.DASHBOARD_FILTERS_EXPERIMENTAL) &&
-      isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) &&
+    (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) &&
       behaviors.includes(Behavior.INTERACTIVE_CHART))
   );
 }