Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sbom_with_creator_and_version rule for cdx version >= 1.5 #284

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

viveksahu26
Copy link
Collaborator

close: #264

update sbom_with_creator_and_version rule for cdx whose spec version >= 1.5.

@riteshnoronha
Copy link
Contributor

@viveksahu26 this change is incorrect. Tools/Components & services are all avaliable since version 1.5 and versions before 1.5 support only Tools.

We should not use cyclonedx versions here but check if the feature is present or not e.g
Populate our internal tools array as folllows

  • if tools->components present then add to our array
  • if tools->services present then add to our array
  • if tools->tools present then add to our array

@viveksahu26
Copy link
Collaborator Author

Yeah got it. Would correct it. Basically, earlier I got bit confused about services that how services can provides tool name, it's version and all. But later read that service is more generalized in terms of tool, Whereas, tool is one of the services. Apart from that, Can you provide CycloneDX SBOMs examples having version 1.5 or 1.6 for testing and all.

Signed-off-by: Vivek Kumar Sahu <[email protected]>
@riteshnoronha riteshnoronha merged commit 20f0b3c into interlynk-io:main Jul 9, 2024
2 checks passed
@viveksahu26 viveksahu26 deleted the issue_264_cdx branch July 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Creator tool and version could be present in services in the tools section for CDX
2 participants