Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timecheck to bsi timestamp #352

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add timecheck to bsi timestamp #352

merged 1 commit into from
Nov 13, 2024

Conversation

warpkwd
Copy link
Contributor

@warpkwd warpkwd commented Nov 12, 2024

It seems that the bsi timestamp has not been time checked, so add it.

viveksahu26
viveksahu26 requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@viveksahu26 viveksahu26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and fix overall! One additional request: could you also update the ntia and oct cases to use the common.CheckTimestamp() function? This will help us follow the DRY principle by reusing the same function for timestamp checks.

viveksahu26
viveksahu26 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@viveksahu26 viveksahu26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Else we will update it later.

@viveksahu26
Copy link
Collaborator

Thanks @warpkwd for your first contributions. Great start 👍 !!

@viveksahu26
Copy link
Collaborator

@warpkwd could you please sign your commits ? Just add -s while commit.

@warpkwd warpkwd force-pushed the bsi_tm_ci branch 2 times, most recently from 95061b2 to 36556ae Compare November 13, 2024 00:05
@warpkwd
Add timecheck to bsi timestamp
9748753 
Signed-off-by: Yukihiro KAWADA <[email protected]>
@viveksahu26 viveksahu26 merged commit bb27163 into interlynk-io:main Nov 13, 2024
2 checks passed
@viveksahu26
Copy link
Collaborator

Thanks again @warpkwd for your first contribution 🎉 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksahu26 viveksahu26 viveksahu26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warpkwd @viveksahu26