Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LazyObject iterable for Python 3 #88

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Make LazyObject iterable for Python 3 #88

merged 2 commits into from
Jul 16, 2020

Conversation

cclauss
Copy link

@cclauss cclauss commented Jul 16, 2020

LazyObject will fail its doctest without these modifications.

@cclauss
Copy link
Author

cclauss commented Jul 16, 2020 •
edited
Loading

Moved to #90 The directive # doctest: +ALLOW_UNICODE is quite helpful in dealing with u'strings' in doctest output however it requires that infogami/infobase/tests/test_doctests.py uses PytestDoctestRunner instead of DocTestRunner.

@cclauss cclauss mentioned this pull request Jul 16, 2020
Closed
@cclauss cclauss mentioned this pull request Jul 16, 2020
Closed
paulproteus
paulproteus approved these changes Jul 16, 2020
View reviewed changes
Copy link

@paulproteus paulproteus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think it can be simplified; see comment. Happy to see it merged or revised, either way.

infogami/infobase/client.py Show resolved Hide resolved
cdrini
cdrini reviewed Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting @paulproteus judgement on this one :)

@cdrini cdrini merged commit 051e3e7 into internetarchive:master Jul 16, 2020
@cclauss cclauss deleted the fix-LazyObject-test branch July 17, 2020 05:50
@cclauss cclauss mentioned this pull request Jul 21, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini left review comments

@paulproteus paulproteus paulproteus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @paulproteus @cdrini