Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose version of the app to the logs on start #83

Closed
hyzhak opened this issue Mar 2, 2018 · 11 comments
Closed

expose version of the app to the logs on start #83

hyzhak opened this issue Mar 2, 2018 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hyzhak
Copy link
Member

hyzhak commented Mar 2, 2018

should get the version from packages.json

@hyzhak hyzhak added enhancement New feature or request good first issue Good for newcomers labels Mar 2, 2018
@hyzhak hyzhak changed the title expose version of the app to the logs expose on start version of the app to the logs Mar 2, 2018
@hyzhak hyzhak changed the title expose on start version of the app to the logs expose version of the app to the logs on start Mar 2, 2018
@bimlendra bimlendra self-assigned this Mar 8, 2018
@bimlendra
Copy link
Collaborator

@hyzhak - Should I just log the version or create a seperate question & expect user to ask current version?

@hyzhak
Copy link
Member Author

hyzhak commented Mar 8, 2018

@bimlendra hm, interesting question. We definitely should put it to the log, but if @markjohngraham don't mind we could add dialog:

USER: what is the version of app?
APP: version is 2.0.5

@bimlendra
Copy link
Collaborator

@markjohngraham has approved the question dialog for app version. So, this question will also be served in the scope against this ticket.

@bimlendra
Copy link
Collaborator

@hyzhak : I am writing code logic for version dialog. Should I still log it on start or just log the version when user ask for version?

@hyzhak
Copy link
Member Author

hyzhak commented Mar 13, 2018

Nothing is change - logging on start is the core feature. The app version on a user request is optional.
Btw could you finish other issues before this one?

@bimlendra
Copy link
Collaborator

@hyzhak : I need to create an intent for this in dialogflow. Please suggestm, if I can made this change?

@hyzhak
Copy link
Member Author

hyzhak commented Mar 13, 2018

@bimlendra sure, but can you finish other issues first?

@bimlendra
Copy link
Collaborator

bimlendra commented Mar 13, 2018

@hyzhak : As per my understanding, I have finished other issues. For process.env in uploader, I have left a question for you.

@hyzhak
Copy link
Member Author

hyzhak commented Mar 13, 2018

@bimlendra not yet, please take a look my comments

@bimlendra
Copy link
Collaborator

bimlendra commented Mar 14, 2018

@hyzhak : which one? I guess, I have resolved all comments related to this ticket.

bimlendra added a commit that referenced this issue Apr 11, 2018
…f-the-app-to-the-logs-on-start

[WIP] #83 expose version of the app to the logs on start
@bimlendra
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants