Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/happy dialog 5 #127

Merged
merged 23 commits into from
Mar 12, 2018
Merged

Feature/happy dialog 5 #127

merged 23 commits into from
Mar 12, 2018

Conversation

hyzhak
Copy link
Member

@hyzhak hyzhak commented Mar 9, 2018 •
edited
Loading

#121

  • user could separately define cover and year
  • add 2 resolvers: short-options and years-interval
  • wrap logger to overwrite debug.log for debug, info, warn, error
  • fixed some bugs of acknowledge message

@hyzhak
fetch years for suggestion list
d115c54
@hyzhak
return plain list of suggested year withou duplications
1c0bb1f
@hyzhak
slice 3 suggestions right before putting to response
265f368
@hyzhak
conver fetch suggestions in a middleware style
8047587
@hyzhak
left comment about further migration after new node support
47a17ae
@hyzhak
slice suggestions right before send ask
a7dac32
@hyzhak
humanize resolver
e7d791b
@hyzhak
convert suggestion humanize to resolver
0f00093
@hyzhak
rename humanized to more specific shortoptions
3d1d3c5
@hyzhak
start using resolver short options instead of suggestions.humanized
81b0835
@hyzhak
drop values field from suggestions list
a1114d5
@hyzhak
add yearinterval resolver
19186a9
@hyzhak
use console.<function>.bind only when we have this logger
ad74c7c
@hyzhak
apply _.values only when suggestion item is object
9aab8af
@hyzhak
only strings are allowed as items of suggestion list
173b193
@hyzhak
don't log promise resolving and proxy logging
ce2b7a5
@hyzhak hyzhak changed the title WIP: Feature/happy dialog 5 Feature/happy dialog 5 Mar 12, 2018
@hyzhak hyzhak merged commit bfae685 into master Mar 12, 2018
@hyzhak hyzhak deleted the feature/happy-dialog-5 branch March 12, 2018 22:30
bimlendra pushed a commit that referenced this pull request Mar 19, 2018
@hyzhak
Merge pull request #127 from internetarchive/feature/happy-dialog-5
a432956 
Feature/happy dialog 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyzhak