Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements_common.txt: Upgrade iptools==0.6.1 for Python 3 and ipv4/ipv6 #1680

Merged
merged 4 commits into from
Dec 10, 2018

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Dec 6, 2018

https://pypi.org/project/iptools v0.4.0 is currently failing our build process on Python 3 because of a syntax error. This PR upgrades to a Python 3 compatible release that also supports the distinction between ipv4 and ipv6

cclauss added 4 commits December 6, 2018 05:27
https://pypi.org/project/iptools is currently [failing our build process](https://travis-ci.org/internetarchive/openlibrary/jobs/464164657#L894) on Python 3 because of a syntax error.  This PR upgrades to a Python 3 compatible release.
To track with changes to the iptools API.
@cclauss cclauss changed the title https://pypi.org/project/iptools/ requirements_common.txt: Upgrade iptools==0.6.1 for Python 3 and ipv4/ipv6 Dec 6, 2018
@mekarpeles mekarpeles merged commit 63db9c4 into internetarchive:master Dec 10, 2018
@cclauss cclauss deleted the patch-6 branch December 10, 2018 21:40
@mekarpeles
Copy link
Member

Seeing issues with:

Traceback (most recent call last):
  File "/opt/openlibrary/deploys/openlibrary/openlibrary/infogami/utils/template.py", line 146, in saferender
    result = t(*a, **kw)
  File "/opt/openlibrary/venv/local/lib/python2.7/site-packages/web/template.py", line 868, in __call__
    return BaseTemplate.__call__(self, *a, **kw)
  File "/opt/openlibrary/venv/local/lib/python2.7/site-packages/web/template.py", line 781, in __call__
    return self._join_output(out)
  File "/opt/openlibrary/venv/local/lib/python2.7/site-packages/web/template.py", line 787, in _join_output
    for name, value in out:
  File "/opt/openlibrary/deploys/openlibrary/openlibrary/openlibrary/templates/type/author/view.html", line 59, in __template__
    $ library = (get_library() if 'inlibrary' in ctx.features else None)
  File "/opt/openlibrary/deploys/openlibrary/openlibrary/openlibrary/core/inlibrary.py", line 106, in get_library
    lib = d_ip.get(web.ctx.ip)

@cclauss
Copy link
Collaborator Author

cclauss commented Dec 10, 2018

Should I revert? What is the actual Exception being raised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants