Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use requests json #3709

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Refactor to use requests json #3709

merged 4 commits into from
Sep 25, 2020

Conversation

aasifkhan7
Copy link
Contributor

Closes #2852
related to #3694

@cclauss clubbed json requests method in this PR.

@aasifkhan7 aasifkhan7 mentioned this pull request Aug 15, 2020
Closed
cclauss
cclauss approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work.

@cclauss cclauss mentioned this pull request Aug 15, 2020
Open
@cdrini cdrini added Priority: 2 Important, as time permits. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] and removed Priority: 2 Important, as time permits. [managed] labels Sep 21, 2020
@cdrini cdrini added this to the Active Sprint milestone Sep 21, 2020
@cclauss
Copy link
Contributor

cclauss commented Sep 23, 2020

Please fix the following https://travis-ci.org/github/internetarchive/openlibrary/jobs/727821530#L600-L605

@aasifkhan7
Copy link
Contributor Author

@cclauss All Travis checks passed.

mekarpeles
mekarpeles approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested on dev w/ @cclauss

openlibrary/catalog/amazon/add_covers.py Show resolved Hide resolved
openlibrary/plugins/upstream/borrow.py Show resolved Hide resolved
openlibrary/plugins/upstream/models.py Show resolved Hide resolved
@mekarpeles mekarpeles merged commit 2477b2b into internetarchive:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@mekarpeles mekarpeles mekarpeles approved these changes

Assignees

@mekarpeles mekarpeles

Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Milestone
Sprint 2020-09
Development

Successfully merging this pull request may close these issues.

Replace all urllib / urllib2 imports and uses with requests
4 participants
@aasifkhan7 @cclauss @mekarpeles @cdrini