Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib.parse.quote() Unicode urls on redirect #4131

Merged
merged 1 commit into from
Nov 20, 2020
Merged

urllib.parse.quote() Unicode urls on redirect #4131

merged 1 commit into from
Nov 20, 2020
+1 −1

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 20, 2020 •
edited
Loading

Closes #3704, #4092

Based on lessons learned from benoitc/gunicorn#2319

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added this to the Active Sprint milestone Nov 20, 2020
@cclauss cclauss marked this pull request as ready for review November 20, 2020 13:07
@cclauss cclauss added the On Staging On staging.openlibrary.org label Nov 20, 2020
seabelis
seabelis approved these changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@seabelis seabelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I am able to edit and save works with unicode characters in their titles without error.

@cclauss cclauss changed the title urlencode Unicode urls on redirect urllib.parse.quote() Unicode urls on redirect Nov 20, 2020
@cclauss cclauss mentioned this pull request Nov 20, 2020
Closed
@cclauss cclauss linked an issue Nov 20, 2020 that may be closed by this pull request
Saving record with non-Latin characters in title throws Internal Server Error #4092
Closed
@mekarpeles
Copy link
Member

Yes, this looks like the right approach to me, thank you

@mekarpeles mekarpeles merged commit bb9709c into internetarchive:master Nov 20, 2020
@cclauss cclauss deleted the urlencode-unicode-urls-on-redirect branch November 20, 2020 21:40
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Python 3: bytes vs. str labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabelis seabelis seabelis approved these changes

@mekarpeles mekarpeles mekarpeles approved these changes

@tfmorris tfmorris Awaiting requested review from tfmorris

@cdrini cdrini Awaiting requested review from cdrini

Assignees
No one assigned
Labels
On Staging On staging.openlibrary.org python Pull requests that update Python code
Projects
None yet
Milestone
Sprint 2020-11
3 participants
@cclauss @mekarpeles @seabelis