Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solr_client.py: Replace urlopen with requests.get #4593

Closed
wants to merge 1 commit into from
Closed

solr_client.py: Replace urlopen with requests.get #4593

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 13, 2021

Subtask of #2852

  • isort --profile black to order the imports
  • Replace urlopen() with requests.get()

Technical

Testing

Screenshot

Stakeholders

@dherbst

@cclauss cclauss mentioned this pull request Feb 15, 2021
Open
@cclauss cclauss added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] On Staging On staging.openlibrary.org labels Mar 1, 2021
@cdrini cdrini mentioned this pull request Mar 5, 2021
Merged
5 tasks
@cdrini
Copy link
Collaborator

cdrini commented Mar 5, 2021

Sigh, this all looks like dead code. Cleaning up in #4729

@cdrini cdrini closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekarpeles mekarpeles Awaiting requested review from mekarpeles

@cdrini cdrini Awaiting requested review from cdrini

Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] On Staging On staging.openlibrary.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @cdrini