Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#137 add bgnpcgn-ron-cyrl-latn-2002 #704

Merged
merged 5 commits into from
May 9, 2021
Merged

#137 add bgnpcgn-ron-cyrl-latn-2002 #704

merged 5 commits into from
May 9, 2021

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented May 7, 2021

  • #137

@CAMOBAP CAMOBAP requested a review from ronaldtse May 7, 2021 08:40
@CAMOBAP CAMOBAP self-assigned this May 7, 2021
@ronaldtse
Copy link
Contributor

@CAMOBAP seems that the CI isn't running. Could you help reactivate it? Thanks!

@CAMOBAP CAMOBAP force-pushed the feature/bgnpcgn-ron-cyrl-latn-2002 branch 5 times, most recently from 71c26ea to c0fc308 Compare May 7, 2021 16:05
@ronaldtse
Copy link
Contributor

@CAMOBAP we're not supposed to need pytorch to run CI?

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented May 7, 2021

we're not supposed to need pytorch to run CI?

locally it works without it, I'm trying to figure out why we need it at all

@CAMOBAP CAMOBAP force-pushed the feature/bgnpcgn-ron-cyrl-latn-2002 branch 12 times, most recently from f4bff3e to 6b60516 Compare May 8, 2021 20:53
@CAMOBAP CAMOBAP force-pushed the feature/bgnpcgn-ron-cyrl-latn-2002 branch from 6b60516 to 5479e0e Compare May 8, 2021 21:23
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented May 8, 2021

@ronaldtse well, CI works more or less:

bgnpcgn-ron-cyrl-latn-2002 passed, so I propose to merge this one

@ronaldtse ronaldtse merged commit 9259442 into master May 9, 2021
@ronaldtse ronaldtse deleted the feature/bgnpcgn-ron-cyrl-latn-2002 branch May 9, 2021 08:02
@ronaldtse ronaldtse mentioned this pull request May 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAMOBAP @ronaldtse