Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-staked with the ability to specify relays for all created stake pools #4234

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Update create-staked with the ability to specify relays for all created stake pools #4234

merged 4 commits into from
Aug 12, 2022
+105 −37

Conversation

Jimbo4350
Copy link
Contributor

Resolves: #4123

@Jimbo4350 Jimbo4350 force-pushed the jordan/create-stake-inject-stake-pool-relays branch 4 times, most recently from aa67bc6 to 3e9d75e Compare July 26, 2022 18:29
@Jimbo4350
Introduce the --relay-specification-file option to the create-staked
06dea0d 
command. This will allow the specification of the pool relays for all of
the created stake pools
@Jimbo4350 Jimbo4350 force-pushed the jordan/create-stake-inject-stake-pool-relays branch from 3e9d75e to 06dea0d Compare August 8, 2022 16:52
deepfire
deepfire approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrated & tested -- good for BORS, from my side.

Thank you a lot @Jimbo4350 !

@deepfire deepfire mentioned this pull request Aug 10, 2022
Closed
@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
@iohk-bors @Jimbo4350
@deepfire @fmaste
Merge #4234 #4285
6ca9c8c 
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

4285: Bench nix refactoring r=deepfire a=fmaste

Cleanups and refactorings that are needed to add the `Docker` backend alongside the `supervisord` backend

- Make backend files (here only `supervisor.nix`) as independent as possible.
- Created a backend subfolder.
- Extracted the code used as configuration for `generator-service`, `node-services` and `tracer-service` outside of the specific backend.
- Remove unused code in the process.

By looking at the individuals commits you can see the approach taken to evolve the code. Small/atomic steps and too much testing. History is for review purposes only, it's intended to be squashed when merged!

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: Federico Mastellone <[email protected]>
@deepfire
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

Canceled.

@deepfire
Copy link
Contributor

deepfire commented Aug 11, 2022 •
edited
Loading

Example relays file:

$ jq . /home/deepfire/.cache/cardano-workbench/genesis/k6-0.006kD-0kU-0a2ce2c/pool-relays.json
{
  "0": [
    {
      "single host name": {
        "dnsName": "node-0",
        "port": 30000
      }
    }
  ],
  "1": [
    {
      "single host name": {
        "dnsName": "node-1",
        "port": 30001
      }
    }
  ],
  "2": [
    {
      "single host name": {
        "dnsName": "node-2",
        "port": 30002
      }
    }
  ],
  "3": [
    {
      "single host name": {
        "dnsName": "node-3",
        "port": 30003
      }
    }
  ],
  "4": [
    {
      "single host name": {
        "dnsName": "node-4",
        "port": 30004
      }
    }
  ],
  "5": [
    {
      "single host name": {
        "dnsName": "node-5",
        "port": 30005
      }
    }
  ]
}

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
@iohk-bors @Jimbo4350 @deepfire
Merge #4234
e4f9915 
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@deepfire deepfire force-pushed the jordan/create-stake-inject-stake-pool-relays branch from 6c5b9ae to 62595bd Compare August 11, 2022 04:02
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

Canceled.

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
@iohk-bors @Jimbo4350 @deepfire
Merge #4234
8ebc700 
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

Build failed:

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
@iohk-bors @Jimbo4350 @deepfire
Merge #4234
7d1bccc 
4234: Update create-staked with the ability to specify relays for all created stake pools r=deepfire a=Jimbo4350

Resolves: #4123

Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

Build failed:

@deepfire deepfire force-pushed the jordan/create-stake-inject-stake-pool-relays branch from 7d1bccc to 3836ff7 Compare August 12, 2022 01:58
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 12, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2b6a78c into master Aug 12, 2022
@iohk-bors iohk-bors bot deleted the jordan/create-stake-inject-stake-pool-relays branch August 12, 2022 02:34
@deepfire deepfire mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@erikd erikd erikd approved these changes

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cardano-cli: feeding ledger peers into genesis create-staked
4 participants
@Jimbo4350 @deepfire @newhoggy @erikd