Trace changes #4561
Merged
Trace changes #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
Jimbo4350,
newhoggy,
deepfire,
denisshevchenko,
jutaro,
a team,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
Jimbo4350
requested changes
Oct 26, 2022
Removed kind field from NodeTo{Node,Client}VersionData
It is not needed, it is obvious from the context that it's either
node-to-node or node-to-client protocol.
Fixed a typo
Changed IP ToJSON instance
There's no need to pack the `ip` address inside a record. It is only
used by: `ToObject` instances of `TraceLocalRootResult` and
`TracePublicRootFailure` constructors.
Simplified ToJSON instance of LocalRootPeers
Switched to using the same data as `LocalRootPeers` in the p2p
topology file (although the format might be different).
Use Notice severity for NetworkConfigUpdate
Added severityStartupTracer
Fixes #4560
|
@Jimbo4350 I squashed all the commits. |
Jimbo4350
approved these changes
Oct 29, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various small changes to traces.
Fixes #4560