-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move style guide to wiki #4703
Move style guide to wiki #4703
Conversation
README.rst
Outdated
**** | ||
Style guide | ||
**** | ||
|
||
The `style guide <https://github.com/input-output-hk/cardano-node/wiki/Style-guide>` for can be found in the wiki. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like that plutus
, ouroboros-network
, the future ouroboros-consensus
and cardano-ledger
are consistent in where style guide can be found.
plutus
:STYLEGUIDE.docs
ouroboros-network
:docs/StyleGuide.md
ouroboros-consensus
(insideouroboros-network
repo):ouroboros-consensus/docs/StyleGuide.md
cardano-node
: a wiki.
I would rather like to move the wiki page to STYLEGUIDE.md
or at least put the link in the STYLEGUIDE.md
document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with docs/StyleGuide.md
is we already have a doc
directory (ie. no s
). I'm not sure what the impact of renaming the directory is.
Would it suffice to rename STYLE.md
to STYLEGUIDE.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd use /STYLEGUIDE.md
; I plan do the same in ouroboros-network
repo once ouroboros-consensus*
migrates to its own repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed.
README.rst
Outdated
Style guide | ||
**** | ||
|
||
The `style guide <https://github.com/input-output-hk/cardano-node/wiki/Style-guide>` for can be found in the wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for cardano-node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the reference to cardano-node
.
902938d
to
7352a57
Compare
7352a57
to
6dad6ab
Compare
No description provided.