Fix bug in hash computation in 'cardano-cli genesis create-cardano'. #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcFontaine
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
* The hash that was used for the genesis files was bad. * Also: Use value passed with '--gen-utxo-keys'.
MarcFontaine
force-pushed
the
mafo/4725-genesis-create-cardano
branch
from
dee2a98
to
db93ac1
Compare
MarcFontaine
changed the title
|
Tested. Works perfectly. |
disassembler
approved these changes
Jan 10, 2023
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4761: Fix bug in hash computation in 'cardano-cli genesis create-cardano'. r=MarcFontaine a=MarcFontaine Use value passed with '--gen-utxo-keys' in 'cardano-cli genesis create-cardano'. Co-authored-by: MarcFontaine <[email protected]>
|
Build failed: |
Jimbo4350
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use value passed with '--gen-utxo-keys' in 'cardano-cli genesis create-cardano'.
Resolves: #4725