-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump haskell.nix #4871
Merged
Merged
Bump haskell.nix #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabedini
force-pushed
the
bump-haskell-nix
branch
from
February 10, 2023 03:08
f835ba2
to
cd5a0d8
Compare
Rebased on top of #4865 to make the evalution work on hydra. |
Some jobs are failing but they seem to be failing on master as well 🤷 Marking this as ready. |
andreabedini
requested review from
Jimbo4350,
newhoggy,
a team,
deepfire,
mgmeier and
fmaste
as code owners
February 14, 2023 06:20
andreabedini
force-pushed
the
bump-haskell-nix
branch
3 times, most recently
from
February 28, 2023 06:45
0ac15da
to
0d62432
Compare
angerman
force-pushed
the
bump-haskell-nix
branch
from
March 6, 2023 01:58
0d62432
to
6ab759d
Compare
angerman
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, even though I'm a bit confused by the amount of things that changed int he flake.lock...
angerman
force-pushed
the
bump-haskell-nix
branch
from
March 6, 2023 06:47
6ab759d
to
ab01698
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Mar 6, 2023
angerman
force-pushed
the
bump-haskell-nix
branch
2 times, most recently
from
March 6, 2023 09:12
6f77553
to
3721aa5
Compare
We need the iohk-nix bump to support newer nixpkgs that lack python37 Signed-off-by: Moritz Angermann <[email protected]>
angerman
force-pushed
the
bump-haskell-nix
branch
from
March 7, 2023 03:39
fdc5ffa
to
976b9ae
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bump is to support cabal file revisions on CHaP which are necessary to get our packages to build without all those manual constraints we have in cabal.project.
I opened a draft PR to test the waters and warm up the chaces ahead of time since it's relatively big change in haskell.nix. I'll make sure everything works and then mark it as ready.