Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump haskell.nix #4871

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Bump haskell.nix #4871

merged 1 commit into from
Mar 7, 2023

Conversation

andreabedini
Copy link
Contributor

@andreabedini andreabedini commented Feb 9, 2023

The bump is to support cabal file revisions on CHaP which are necessary to get our packages to build without all those manual constraints we have in cabal.project.

I opened a draft PR to test the waters and warm up the chaces ahead of time since it's relatively big change in haskell.nix. I'll make sure everything works and then mark it as ready.

@andreabedini
Copy link
Contributor Author

Rebased on top of #4865 to make the evalution work on hydra.

@andreabedini
Copy link
Contributor Author

Some jobs are failing but they seem to be failing on master as well 🤷 Marking this as ready.

Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though I'm a bit confused by the amount of things that changed int he flake.lock...

@angerman angerman added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 6, 2023
@angerman angerman force-pushed the bump-haskell-nix branch 2 times, most recently from 6f77553 to 3721aa5 Compare March 6, 2023 09:12
We need the iohk-nix bump to support newer nixpkgs that
lack python37

Signed-off-by: Moritz Angermann <[email protected]>
@angerman angerman added this pull request to the merge queue Mar 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2023
@angerman angerman added this pull request to the merge queue Mar 7, 2023
Merged via the queue into master with commit 2120fac Mar 7, 2023
@iohk-bors iohk-bors bot deleted the bump-haskell-nix branch March 7, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants