Preserve ScriptData bytes with HashableScriptData
#4886
Merged
+284
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
5 times, most recently
from
0350341
to
9f460bf
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
approved these changes
Feb 14, 2023
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
4 times, most recently
from
b0604dc
to
b05dec3
Compare
JaredCorduan
approved these changes
Feb 16, 2023
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
from
b05dec3
to
9bc4980
Compare
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
2 times, most recently
from
b03965b
to
26008d1
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 17, 2023
4831: Refactor `genesis create` command usage in cardano testnet r=Jimbo4350 a=Jimbo4350 Implement the following three modules: 1. Testnet.Commands.Genesis - Houses the refactoring of cli commands concerning genesis generation 2. Testnet.Commands.Governance - Houses the refactoring of cli commands concerning governance 3. Testnet.Options - Module that will house all the different `TestnetOptions` types. The aim is to only have one `TestnetOptions` type in the future. 4886: Preserve `ScriptData` bytes with `HashableScriptData` r=Jimbo4350 a=Jimbo4350 Resolves: #4433 Co-authored-by: Jordan Millar <[email protected]>
|
bors r- |
|
Canceled. |
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
from
26008d1
to
b667b37
Compare
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
from
b667b37
to
e4affa1
Compare
…ed with the `HashableScriptData` type. Prior to this commit we were constructing transactions with `toAlonzoData` which created a ledger `Data` value without using the original bytes. Although the content is the same this can result in the re-encoded value differing slightly and therefore resulting in differing script data hashes. See: IntersectMBO/cardano-ledger#2943 for more details.
Jimbo4350
force-pushed
the
jordan/preserve-original-bytes
branch
from
a8ca187
to
5457bd9
Compare
newhoggy
pushed a commit
to IntersectMBO/cardano-api
that referenced
this pull request
May 23, 2023
was introduced by IntersectMBO/cardano-node#4886 readScriptDataOrFile was reverted to read ScriptData json with the detailed schema format (ScriptDataJsonDetailedSchema)
newhoggy
pushed a commit
to IntersectMBO/cardano-cli
that referenced
this pull request
May 24, 2023
was introduced by IntersectMBO/cardano-node#4886 readScriptDataOrFile was reverted to read ScriptData json with the detailed schema format (ScriptDataJsonDetailedSchema)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4433