Skip to content

Commit

Permalink
migration and deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
shauke committed Aug 21, 2024
1 parent 65afae9 commit b2623fb
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions docs/guides/migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ kb_sync_latest_only

# Migrations

## From 5.2 to 5.3

With ICM 12.2.0, 11.11.1 or 7.10.41.3 the ICM server itself provides an OCI punchout URL (Pipeline) that works better for the OCI punchout functions `BACKGROUND_SEARCH` and `VALIDATE` than the similar now deprecated functionality in the PWA.
For that reason the provided OCI Punchout URL is now pointing to the ICM pipeline `ViewOCICatalogPWA-Start` that handles the different functionalities and redirects to the PWA (configured as _External Base URL_ in ICM) only for catalog browsing and the detail function.

## From 5.1 to 5.2

> [!NOTE]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export class PunchoutIdentityProvider implements IdentityProvider {
if (route.queryParamMap.get('FUNCTION') === 'DETAIL' && route.queryParamMap.get('PRODUCTID')) {
return of(this.router.parseUrl(`/product/${route.queryParamMap.get('PRODUCTID')}`));

// Validation of Products
// Validation of Products - @deprecated This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`.
} else if (route.queryParamMap.get('FUNCTION') === 'VALIDATE' && route.queryParamMap.get('PRODUCTID')) {
return this.punchoutService
.getOciPunchoutProductData(route.queryParamMap.get('PRODUCTID'), route.queryParamMap.get('QUANTITY') || '1')

Check warning on line 184 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / CommandLine

"getOciPunchoutProductData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check failure on line 184 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / Quality

"getOciPunchoutProductData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check warning on line 184 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / GitBash

"getOciPunchoutProductData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check warning on line 184 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / Powershell

"getOciPunchoutProductData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`
Expand All @@ -187,7 +187,7 @@ export class PunchoutIdentityProvider implements IdentityProvider {
map(() => false)
);

// Background Search
// Background Search - @deprecated: is now handled by the ICM ViewOCICatalogPWA-Start pipeline
} else if (route.queryParamMap.get('FUNCTION') === 'BACKGROUND_SEARCH' && route.queryParamMap.get('SEARCHSTRING')) {
return this.punchoutService.getOciPunchoutSearchData(route.queryParamMap.get('SEARCHSTRING')).pipe(

Check warning on line 192 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / CommandLine

"getOciPunchoutSearchData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check failure on line 192 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / Quality

"getOciPunchoutSearchData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check warning on line 192 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / GitBash

"getOciPunchoutSearchData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`

Check warning on line 192 in src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts

View workflow job for this annotation

GitHub Actions / Powershell

"getOciPunchoutSearchData" is deprecated: This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`
tap(data => this.punchoutService.submitOciPunchoutData(data, false)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,8 @@ export class PunchoutService {
*
* @param productId The product id (SKU) of the product to validate.
* @param quantity The quantity for the validation (default: '1').
*
* @deprecated This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`.
*/
getOciPunchoutProductData(productId: string, quantity = '1'): Observable<Attribute<string>[]> {
if (!productId) {
Expand Down Expand Up @@ -420,6 +422,8 @@ export class PunchoutService {
* Gets a JSON object with the necessary OCI punchout data for the background search.
*
* @param searchString The search string to search punchout products.
*
* @deprecated This functionality should be handled by the ICM pipeline `ViewOCICatalogPWA-Start`.
*/
getOciPunchoutSearchData(searchString: string): Observable<Attribute<string>[]> {
if (!searchString) {
Expand Down

0 comments on commit b2623fb

Please sign in to comment.