Skip to content

Commit

Permalink
refactor: accessibility - adjust colors to have a sufficient contrast…
Browse files Browse the repository at this point in the history
… ratio - add new gray color #6b6b6b, consolidate text color variables
  • Loading branch information
andreassteinmann committed Aug 21, 2024
1 parent 329197d commit e96ad20
Show file tree
Hide file tree
Showing 26 changed files with 49 additions and 49 deletions.
2 changes: 1 addition & 1 deletion src/styles/components/cookies.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
text-decoration: underline;

&:hover {
color: $text-color-quaternary !important;
color: $text-color-tertiary !important;
}

@media (max-width: $screen-xs-max) {
Expand Down
4 changes: 2 additions & 2 deletions src/styles/components/footer/footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

footer {
clear: both;
color: $text-color-secondary;
color: $text-color-tertiary;

// h4 is obsolete, should use .link-group-heading instead
h4,
Expand Down Expand Up @@ -71,7 +71,7 @@ footer {
a,
a:not([href]):not([tabindex]) {
font-family: $font-family-condensedregular;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-decoration: none;

&:hover {
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/header/header-sticky.scss
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
.ng-fa-icon {
&.header-icon {
padding: 0 10px;
color: $text-color-secondary;
color: $text-color-tertiary;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/header/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ header {
padding-right: ($space-default * 1.5);
font-family: $font-family-bold;
font-size: 12px;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-transform: uppercase;
list-style: none;

Expand Down
4 changes: 2 additions & 2 deletions src/styles/components/header/main-navigation.scss
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
.category-level3,
.category-level4 {
> li > a {
color: $text-color-tertiary;
color: $text-color-quaternary;
}
}
}
Expand Down Expand Up @@ -232,7 +232,7 @@

a {
font-size: $font-size-sub-menu-item;
color: $text-color-tertiary;
color: $text-color-quaternary;
text-transform: none;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/header/search-container.scss
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
font-family: $font-family-regular;
font-size: 13px;
line-height: 47px;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-align: left;
background: none;
border: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/header/user-information-mobile.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
display: flex;
font-family: $font-family-bold;
font-size: 12px;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-transform: uppercase;
}

Expand Down
4 changes: 2 additions & 2 deletions src/styles/global/breadcrumbs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@

a {
font-size: 12px;
color: $text-color-quaternary;
color: $text-color-tertiary;

&:hover {
color: $text-color-tertiary;
color: $text-color-quaternary;
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/styles/global/buttons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

&.disabled,
&:disabled {
color: $text-color-primary;
color: $text-color-secondary;
background-color: $color-tertiary;
border-color: $border-color-light;
}
Expand Down Expand Up @@ -94,7 +94,7 @@

&.disabled,
&:disabled {
color: $text-color-primary;
color: $text-color-secondary;
border-color: $border-color-light;
}

Expand Down
4 changes: 2 additions & 2 deletions src/styles/global/forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ fieldset {

// REQUIRED FIELDS
.indicates-required {
color: $text-color-quaternary;
color: $text-color-tertiary;

.required {
margin-right: 4px;
Expand Down Expand Up @@ -140,7 +140,7 @@ input.form-check-input {
}

.input-help {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

select {
Expand Down
8 changes: 4 additions & 4 deletions src/styles/global/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ h3,
.header-note {
font-family: $font-family-regular;
font-size: $font-size-corporate;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-transform: none;
}

Expand Down Expand Up @@ -115,7 +115,7 @@ a {
}

h3:hover {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

&.teaser-link {
Expand Down Expand Up @@ -291,12 +291,12 @@ img {
// Help Text
.form-text {
margin: divide($space-default, 3) 0 $space-default * 0.5;
color: $text-color-quaternary;
color: $text-color-tertiary;
}

h2.form-text {
font-family: $font-family-regular;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-transform: none;
}

Expand Down
2 changes: 1 addition & 1 deletion src/styles/global/lists.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// General class for status 'deactivated' in general lists
.inactive {
*:not(a) {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

a {
Expand Down
4 changes: 2 additions & 2 deletions src/styles/pages/account/account-dashboard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@

.dashboard-item {
margin-bottom: ($space-default * 2);
color: $text-color-secondary;
color: $text-color-tertiary;
text-align: center;
text-transform: uppercase;

a {
font-size: 13px;
color: $text-color-secondary;
color: $text-color-tertiary;

&:hover {
text-decoration: none;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/category/category.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
.old-price {
margin-bottom: $space-default * 0.5;
font-family: $font-family-condensedregular;
color: $text-color-tertiary;
color: $text-color-quaternary;

.price-value {
text-decoration: line-through;
Expand Down
8 changes: 4 additions & 4 deletions src/styles/pages/category/filter-panel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@
li {
&.filter-item {
padding: 3px 0;
color: $text-color-quaternary;
color: $text-color-tertiary;

a,
.btn-link-action {
display: block;

&.filter-item-name {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

&.filter-swatch {
Expand Down Expand Up @@ -134,7 +134,7 @@

span {
font-weight: normal;
color: $text-color-quaternary;
color: $text-color-tertiary;

&.icon-selected {
display: inline-block;
Expand All @@ -147,7 +147,7 @@
}

&.filter-color {
border-color: $text-color-quaternary;
border-color: $text-color-tertiary;

a,
.btn-link-action {
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/category/filter-row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
&.list-view-link,
&.list-view-link:hover,
&.list-view-link:focus {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

&.grid-view-link {
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/category/product-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
.scaled-prices {
margin-bottom: $space-default;
font-family: $font-family-condensedregular;
color: $text-color-quaternary;
color: $text-color-tertiary;
}

.product-list-container {
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/checkout/checkout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}

.cart-pli-data {
color: $text-color-quaternary;
color: $text-color-tertiary;

span {
display: inline-block;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/checkout/progress-bar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
width: 20%;
padding-left: $space-default;
line-height: 50px;
color: $text-color-primary;
color: $text-color-secondary;
border-bottom: 4px solid $border-color-light;

@media (max-width: $screen-xs-max) {
Expand Down
8 changes: 4 additions & 4 deletions src/styles/pages/checkout/quick-cart.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
text-transform: uppercase;

span {
color: $text-color-quaternary;
color: $text-color-secondary;

&.mini-cart-price {
font-size: $font-size-base;
Expand All @@ -24,7 +24,7 @@
padding: 0 !important;
margin-right: ($space-default * 0.5);
font-size: 17px;
color: $text-color-quaternary;
color: $text-color-secondary;
}
}

Expand Down Expand Up @@ -118,7 +118,7 @@
font-family: $font-family-condensedregular;
font-size: $font-size-base;
font-weight: normal;
color: $text-color-quaternary;
color: $text-color-tertiary;
text-overflow: ellipsis;
text-transform: none;
white-space: nowrap;
Expand All @@ -133,7 +133,7 @@

.cart-pli-data {
font-size: 85%;
color: $text-color-quaternary;
color: $text-color-tertiary;

span {
display: inline-block;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/checkout/shopping-cart.scss
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
padding: ($space-default * 4) 0 0;
font-family: $font-family-bold;
font-size: 70px;
color: $text-color-quaternary;
color: $text-color-tertiary;
}

h2 {
Expand Down
4 changes: 2 additions & 2 deletions src/styles/pages/productdetail/product-info.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ a.product-title {

.product-id {
font-size: $font-size-corporate;
color: $text-color-quaternary;
color: $text-color-tertiary;

.product-id-label {
padding-right: divide($space-default, 3);
Expand All @@ -20,7 +20,7 @@ a.product-title {

.product-info {
font-family: $font-family-condensedregular;
color: $text-color-quaternary;
color: $text-color-tertiary;

.label-quantity {
text-transform: uppercase;
Expand Down
6 changes: 3 additions & 3 deletions src/styles/pages/productdetail/productdetail.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
padding: divide($space-default, 3) 0;

a {
color: $text-color-quaternary;
color: $text-color-tertiary;

&:hover {
color: $text-color-tertiary;
color: $text-color-quaternary;
}
}

Expand Down Expand Up @@ -135,7 +135,7 @@
margin-bottom: $space-default * 2;

.review-item-created {
color: $text-color-quaternary;
color: $text-color-tertiary;
}

.review-item-header-title {
Expand Down
8 changes: 4 additions & 4 deletions src/styles/themes/b2b/variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ $CORPORATE-SHADOW: #7f9ecc80; // with alpha transparency
$text-color-corporate: $CORPORATE-PRIMARY;

$text-color-primary: #222;
$text-color-secondary: #757575;
$text-color-tertiary: #8b8b8b;
$text-color-quaternary: #757575;
$text-color-secondary: #6b6b6b;
$text-color-tertiary: #757575;
$text-color-quaternary: #8b8b8b;
$text-color-quinary: #eee;

$text-color-inverse: #fff;
Expand Down Expand Up @@ -210,7 +210,7 @@ $headings-color: $text-color-primary;
// Shared variables that are reassigned to `$input-` and `$btn-` specific variables.

// Forms
$input-placeholder-color: $text-color-quaternary;
$input-placeholder-color: $text-color-tertiary;
$input-accent-color: #222;

// Dropdown
Expand Down
6 changes: 3 additions & 3 deletions src/styles/themes/b2c/properties.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
// TEXT COLOR
--text-color-corporate: var(--corporate-primary);
--text-color-primary: #222;
--text-color-secondary: #757575;
--text-color-tertiary: #8b8b8b;
--text-color-quaternary: #757575;
--text-color-secondary: #6b6b6b;
--text-color-tertiary: #757575;
--text-color-quaternary: #8b8b8b;
--text-color-quinary: #eee;

// GENERAL COLORS
Expand Down
2 changes: 1 addition & 1 deletion src/styles/themes/b2c/variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ $headings-color: $text-color-primary;
// Shared variables that are reassigned to `$input-` and `$btn-` specific variables.

// Forms
$input-placeholder-color: $text-color-quaternary;
$input-placeholder-color: $text-color-tertiary;
$input-accent-color: #222;

// Dropdown
Expand Down

0 comments on commit e96ad20

Please sign in to comment.