feat: wishlist sharing #1590
Open
feat: wishlist sharing #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Mar 5, 2024
SGrueber
requested changes
Apr 5, 2024
...app/extensions/wishlists/shared/wishlist-sharing-dialog/wishlist-sharing-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/models/wishlist-sharing/wishlist-sharing.model.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/pages/wishlist/wishlist-page.component.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/store/wishlist/wishlist.reducer.ts
Outdated
Show resolved
Hide resolved
...extensions/wishlists/pages/account-wishlist-detail/account-wishlist-detail-page.component.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/pages/wishlist/wishlist-line-item/wishlist-line-item.component.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/pages/wishlist/wishlist-page.component.html
Outdated
Show resolved
Hide resolved
src/app/extensions/wishlists/pages/wishlist/wishlist-page.component.html
Outdated
Show resolved
Hide resolved
...xtensions/wishlists/shared/wishlist-sharing-dialog/wishlist-sharing-dialog.component.spec.ts
Show resolved
Hide resolved
SGrueber
force-pushed
the
feature/wishlist-sharing
branch
from
104422d
to
bfc4abd
Compare
M-Behr
requested changes
Sep 30, 2024
There was a problem hiding this comment.
- please check mobil view
- Shared wish lists could be labeled in the wish list overview. Example:
- if list is not shared anymore and the other user is logged out and opens the URL: empty page with error message "not found" is visible --> page not found page would be better
- if list is not shared anymore and the other user is logged in and opens the URL: wishlist is visible and will be updated, error message can be ignored by the user --> page not found should be visible
See here: https://pwa-gh-review-feature-wishlist-sharing.azurewebsites.net/b2c/wishlists/upxA8AFl0M4AAAGSdHoADkKl?owner=7UFA8AVnAXgAAAGRlpgADVn4&secureCode=408ac0b1-c770-4830-9046-e672822dce84 - 2 requests and responds are sent
SGrueber
requested changes
Oct 4, 2024
|
Ami will review French, so please do not merge beforehand. |
mglatter
previously approved these changes
Oct 15, 2024
- floating buttons changed to normal icon buttons and tooltip with text added - added a label in the wishlist list to indicate that the wishlist is shared - fixed the problems when the wishlist is no longer shared -> redirect to error page - fixed the problem with duplicate requests - added a separate state for the shared wishlist so that logged in users can use the link to the shared wishlist
mglatter
reviewed
Oct 16, 2024
mglatter
previously approved these changes
Oct 16, 2024
|
Azure Demo Servers are available: |
|
The status Shared should not be appended to the name.
|
|
Thanks for the fixes.
|
- fix padding left for shared and preferred - button group is in one line with the heading - use the base url for link, but consider multi-channel baseHref configurations - fix e2e test
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
iwiederhold
approved these changes
Oct 24, 2024
M-Behr
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Design issues are fixed. Well done!
@SGrueber follwing problem still exists:
I share my wish list to a friend. The friend can open it via link. I unshare my wish list. My friend can open it again with the link. If the friend uses another browser, the error page appears (this is correct). It looks like a caching problem. Could you check this, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The wishlist sharing feature is missing in the PWA.
What Is the New Behavior?
The wishlist sharing (B2C only) functionality is now added to the PWA
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
requires ICM-AS 11.10.0
AB#94495