CommandWithArguments must use .multiple() instead of .multiple_values…

…(), see clap-rs#2031
intgr · Jul 21, 2020 · 0b3d8fb · 0b3d8fb
1 parent 44c4fde
commit 0b3d8fb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/clap_generate/examples/value_hints.rs b/clap_generate/examples/value_hints.rs
@@ -73,7 +73,7 @@ fn build_cli() -> App<'static> {
         )
         .arg(
             Arg::new("command_with_args")
-                .multiple_values(true)
+                .multiple(true)
                 .value_hint(ValueHint::CommandWithArguments),
         )
         .arg(

diff --git a/clap_generate/tests/value_hints.rs b/clap_generate/tests/value_hints.rs
@@ -56,7 +56,7 @@ pub fn build_app_with_value_hints() -> App<'static> {
         )
         .arg(
             Arg::new("command_with_args")
-                .multiple_values(true)
+                .multiple(true)
                 .value_hint(ValueHint::CommandWithArguments),
         )
         .arg(

diff --git a/src/build/arg/mod.rs b/src/build/arg/mod.rs
@@ -4233,8 +4233,9 @@ impl<'a> Arg<'a> {
 
             if self.value_hint == ValueHint::CommandWithArguments {
                 assert!(
-                    self.is_set(ArgSettings::MultipleValues),
-                    "Argument '{}' uses hint CommandWithArguments and must accept multiple values",
+                    self.is_set(ArgSettings::MultipleOccurrences)
+                        && self.is_set(ArgSettings::MultipleValues),
+                    "Argument '{}' uses hint CommandWithArguments and must use .multiple(true)",
                 )
             }
         }