Merge pull request #1803 from intuit/upload-assets-canary

make canary assets tag at the start of history to avoid tag calculation bugs
intuit · Feb 12, 2021 · 0efae8f · 0efae8f
2 parents f0cb6e2 + 1b9daca
commit 0efae8f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/plugins/upload-assets/__tests__/upload-assets-ci.test.ts b/plugins/upload-assets/__tests__/upload-assets-ci.test.ts
@@ -43,6 +43,7 @@ describe("Upload Assets Plugin", () => {
       prefixRelease: (v) => v,
       git: {
         options,
+        getFirstCommit: () => 'abc',
         addToPrBody,
         github: {
           repos: { uploadReleaseAsset, createRelease },

diff --git a/plugins/upload-assets/__tests__/upload-assets.test.ts b/plugins/upload-assets/__tests__/upload-assets.test.ts
@@ -115,6 +115,7 @@ describe("Upload Assets Plugin", () => {
       logger: dummyLog(),
       prefixRelease: (v) => v,
       git: {
+        getFirstCommit: () => 'abc',
         options,
         github: {
           repos: { uploadReleaseAsset, createRelease },
@@ -192,6 +193,7 @@ describe("Upload Assets Plugin", () => {
       prefixRelease: (v) => v,
       git: {
         options,
+        getFirstCommit: () => 'abc',
         github: {
           repos: { uploadReleaseAsset, createRelease },
           paginate: jest.fn().mockResolvedValue([]),
@@ -226,6 +228,7 @@ describe("Upload Assets Plugin", () => {
       prefixRelease: (v) => v,
       git: {
         options,
+        getFirstCommit: () => 'abc',
         github: {
           repos: { uploadReleaseAsset, createRelease },
           paginate: jest.fn().mockResolvedValue([]),

diff --git a/plugins/upload-assets/src/index.ts b/plugins/upload-assets/src/index.ts
@@ -262,6 +262,7 @@ export default class UploadAssetsPlugin implements IPlugin {
         name: "Canary Assets",
         prerelease: true,
         body: `This release contains preview assets of Pull Requests.`,
+        target_commitish: await auto.git?.getFirstCommit()
       });
 
       return canaryRelease.data;