Merge pull request #1762 from intuit/npm-bug

fix commit message when using npx in non-monorepo
intuit · Jan 28, 2021 · 1bcc639 · 1bcc639
2 parents 8456b2a + 57ea93f
commit 1bcc639
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/plugins/npm/__tests__/npm.test.ts b/plugins/npm/__tests__/npm.test.ts
@@ -489,7 +489,7 @@ describe("publish", () => {
       Auto.SEMVER.patch,
       "--no-commit-hooks",
       "-m",
-      "Bump version to: %s [skip ci]",
+      "'\"Bump version to: %s [skip ci]\"'",
       "--loglevel",
       "silly",
     ]);
@@ -519,7 +519,7 @@ describe("publish", () => {
       Auto.SEMVER.patch,
       "--no-commit-hooks",
       "-m",
-      "Bump version to: %s [skip ci]",
+      "'\"Bump version to: %s [skip ci]\"'",
     ]);
   });
 
@@ -554,7 +554,7 @@ describe("publish", () => {
       "--yes",
       "--no-push",
       "-m",
-      '\'"Bump version to: %s [skip ci]"\'',
+      "'\"Bump version to: %s [skip ci]\"'",
       false,
     ]);
   });
@@ -590,7 +590,7 @@ describe("publish", () => {
       "--yes",
       "--no-push",
       "-m",
-      '\'"Bump version to: %s [skip ci]"\'',
+      "'\"Bump version to: %s [skip ci]\"'",
       false,
     ]);
   });
@@ -626,7 +626,7 @@ describe("publish", () => {
       "--yes",
       "--no-push",
       "-m",
-      '\'"Bump version to: %s [skip ci]"\'',
+      "'\"Bump version to: %s [skip ci]\"'",
       "--exact",
     ]);
 
@@ -750,7 +750,7 @@ describe("publish", () => {
       "1.0.1",
       "--no-commit-hooks",
       "-m",
-      "Bump version to: %s [skip ci]",
+      "'\"Bump version to: %s [skip ci]\"'",
     ]);
   });
 
@@ -786,7 +786,7 @@ describe("publish", () => {
       "--yes",
       "--no-push",
       "-m",
-      '\'"Bump version to: %s [skip ci]"\'',
+      "'\"Bump version to: %s [skip ci]\"'",
       false,
     ]);
   });

diff --git a/plugins/npm/src/index.ts b/plugins/npm/src/index.ts
@@ -35,7 +35,7 @@ import setTokenOnCI, { getRegistry, DEFAULT_REGISTRY } from "./set-npm-token";
 import { writeFile, isMonorepo, readFile, getLernaJson } from "./utils";
 
 const { isCi } = envCi();
-const VERSION_COMMIT_MESSAGE = "Bump version to: %s [skip ci]";
+const VERSION_COMMIT_MESSAGE = `'"Bump version to: %s [skip ci]"'`;
 
 /** Get the last published version for a npm package */
 async function getPublishedVersion(name: string) {
@@ -947,7 +947,7 @@ export default class NPMPlugin implements IPlugin {
             "-m",
             isIndependent
               ? '"Bump independent versions [skip ci]"'
-              : `'"${VERSION_COMMIT_MESSAGE}"'`,
+              : VERSION_COMMIT_MESSAGE,
             this.exact && "--exact",
             ...verboseArgs,
           ]);