fix publish and test coverage for publish

intuit · Sep 4, 2020 · 73ac526 · 73ac526
1 parent be4aa01
commit 73ac526
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 1 deletion.
diff --git a/plugins/docker/__tests__/docker.test.ts b/plugins/docker/__tests__/docker.test.ts
@@ -135,6 +135,31 @@ describe("Docker Plugin", () => {
         `${registry}:1.0.1`,
       ]);
     });
+
+    test("should tag latest", async () => {
+      const sourceImage = "app:sha-123";
+      const hooks = setup(
+        { getLatestTagInBranch: () => "v1.0.0" },
+        { registry, image: sourceImage, tagLatest: true }
+      );
+      await hooks.version.promise(Auto.SEMVER.patch);
+      expect(exec).toHaveBeenCalledWith("git", [
+        "tag",
+        "1.0.1",
+        "-m",
+        '"Update version to 1.0.1"',
+      ]);
+      expect(exec).toHaveBeenCalledWith("docker", [
+        "tag",
+        sourceImage,
+        `${registry}:1.0.1`,
+      ]);
+      expect(exec).toHaveBeenCalledWith("docker", [
+        "tag",
+        sourceImage,
+        `${registry}:latest`,
+      ]);
+    });
   });
 
   describe("canary", () => {
@@ -209,4 +234,48 @@ describe("Docker Plugin", () => {
       ]);
     });
   });
+
+  describe("publish", () => {
+    test("should publish next version", async () => {
+      const sourceImage = "app:sha-123";
+      const hooks = setup(
+        {
+          getLatestTagInBranch: () => "v1.0.0",
+          getCurrentBranch: () => "master",
+          remote: "github.com",
+        },
+        { registry, image: sourceImage, tagLatest: false }
+      );
+      await hooks.version.promise(Auto.SEMVER.patch);
+
+      await hooks.publish.promise(Auto.SEMVER.patch);
+      expect(exec).toHaveBeenCalledWith("docker", [
+        "push",
+        `${registry}:1.0.1`,
+      ]);
+    });
+
+    test("should publish latest", async () => {
+      const sourceImage = "app:sha-123";
+      const hooks = setup(
+        {
+          getLatestTagInBranch: () => "v1.0.0",
+          getCurrentBranch: () => "master",
+          remote: "github.com",
+        },
+        { registry, image: sourceImage, tagLatest: true }
+      );
+      await hooks.version.promise(Auto.SEMVER.patch);
+
+      await hooks.publish.promise(Auto.SEMVER.patch);
+      expect(exec).toHaveBeenCalledWith("docker", [
+        "push",
+        `${registry}:1.0.1`,
+      ]);
+      expect(exec).toHaveBeenCalledWith("docker", [
+        "push",
+        `${registry}:latest`,
+      ]);
+    });
+  });
 });
diff --git a/plugins/docker/src/index.ts b/plugins/docker/src/index.ts
@@ -174,7 +174,9 @@ export default class DockerPlugin implements IPlugin {
       auto.logger.log.info("Pushing new tag to GitHub");
 
       await Promise.all(
-        this.calculatedTags!.map((tag) => execPromise("docker", ["push", tag]))
+        this.calculatedTags!.map((tag) =>
+          execPromise("docker", ["push", `${this.options.registry}:${tag}`])
+        )
       );
 
       await execPromise("git", [