Deprecation: [@octokit/request-error] error.headers is deprecated, use error.response.headers.

[mijdavis2]

Describe the bug

Any command now outputs the following:

Deprecation: [@octokit/request-error] `error.headers` is deprecated, use `error.response.headers`.

To Reproduce

• Install auto
• Run a command like auto changelog

Expected behavior

No deprecation warning

Screenshots

Environment information:

Environment Information:

"auto" version: v10.30.0
"git"  version: v2.30.2
"node" version: v14.17.0

Additional context

[hipstersmoothie]

I think this might be some deps that need updating. If anyone has the time to make these updates any and all PRs welcome!

[npvisual]

Note : I don't think that has been addressed as I am still seeing it in 10.36.5.

Is it possible to re-open the issue ?

The current warning is identical to the warning reported above.

% yarn --silent auto version
Deprecation: [@octokit/request-error] `error.headers` is deprecated, use `error.response.headers`.
    at RequestError.get (/Users/nicolasphilippe/Mperativ/GitHub/auto/node_modules/@octokit/core/node_modules/@octokit/request/node_modules/@octokit/request-error/dist-src/index.js:50:32)
    at /Users/nicolasphilippe/Mperativ/GitHub/auto/packages/core/src/git.ts:171:24
    at /Users/nicolasphilippe/Mperativ/GitHub/auto/node_modules/before-after-hook/lib/add.js:37:18
    at Git.getUserByUsername (/Users/nicolasphilippe/Mperativ/GitHub/auto/packages/core/src/git.ts:480:20)
minor

% yarn list --pattern auto
yarn list v1.22.18
warning package.json: No license field
warning No license field
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
├─ @auto-it/[email protected]
└─ [email protected]
✨  Done in 0.25s.

The problem seems to come from this statement in git.ts, since commenting that out will remove the warning :

    this.github.hook.error("request", (error) => {
      if (error) {
        // narrow down the type
        if ("headers" in error && error.request.headers.authorization) {
          delete error.request.headers.authorization;
          delete error.headers.authorization;                <-------- error.headers deprecated
        }
      }

The PR doesn't seem to modify this file at all.

I am not totally sure what the best course of action is here so please @hipstersmoothie advise.

[hipstersmoothie]

Could you open a pr?

[intuit-svc]

🚀 Issue was released in v10.36.6 🚀