Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade eslint + ensure all imported packages are in package.json #1442

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Aug 6, 2020

What Changed

See title

Why

We had a lot of deps that weren't in their respective package.json. This was breaking some package imports for yarn v2.

📦 Published PR as canary version: under canary scope @[email protected]

✨ Test out this PR locally via:

npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
# or 
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1442 into master will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   80.81%   80.78%   -0.03%     
==========================================
  Files          58       58              
  Lines        4285     4294       +9     
  Branches      945      949       +4     
==========================================
+ Hits         3463     3469       +6     
- Misses        583      586       +3     
  Partials      239      239              
Impacted Files Coverage Δ
packages/cli/src/bin/auto.ts 17.64% <0.00%> (ø)
packages/cli/src/parse-args.ts 97.29% <ø> (ø)
packages/core/src/init.ts 20.17% <ø> (ø)
packages/core/src/utils/load-plugins.ts 81.18% <ø> (ø)
packages/core/src/utils/logger.ts 70.00% <ø> (ø)
plugins/first-time-contributor/src/index.ts 86.66% <0.00%> (ø)
packages/core/src/auto.ts 77.21% <44.44%> (-0.27%) ⬇️
plugins/git-tag/src/index.ts 83.72% <50.00%> (+0.38%) ⬆️
plugins/npm/src/index.ts 73.08% <50.00%> (+0.05%) ⬆️
packages/cli/src/run.ts 24.61% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75458a3...5d5edcb. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 130a7a8 into master Aug 6, 2020
@hipstersmoothie hipstersmoothie deleted the unresolved-deps branch August 6, 2020 22:53
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.49.5 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants