Add Docker Publish Plugin #1510
Conversation
plugins/docker/src/index.ts
Outdated
| if (Array.isArray(options)) { | ||
| const errors = await Promise.all( | ||
| options.map((o) => | ||
| validatePluginConfiguration(this.name, pluginOptions, o) | ||
| ) | ||
| ); | ||
|
|
||
| return errors.reduce((acc, item) => [...acc, ...item], []); | ||
| } |
There was a problem hiding this comment.
I don't think this if statement is necessary. This would validate if a user provided an array of this plugin's option. I don't think this plugin allows for that
There was a problem hiding this comment.
Good catch, got copy pasta'd. Tempted to add this later, but not necessary now.
| } | ||
| }); | ||
|
|
||
| auto.hooks.canary.tapPromise(this.name, async (version, postFix) => { |
There was a problem hiding this comment.
Ooh nice! canary release is sweet
There was a problem hiding this comment.
Seemed simple and a no-brainer to add :)
Doing so now! Maybe because of Windows, a full |
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 81.09% 81.20% +0.11%
==========================================
Files 58 59 +1
Lines 4316 4395 +79
Branches 914 979 +65
==========================================
+ Hits 3500 3569 +69
- Misses 571 572 +1
- Partials 245 254 +9
Continue to review full report at Codecov.
|
|
Should be green and good now! Actually caught a logic bug with tests, so that's nice. Not sure how strict ya'll are about coverage, but at least worked to get green with codecov. |
|
@RichiCoder1 last few things: |
|
Done! Do I need to regen docs or is that done as part of CI/Release? |
that's part of the release! |
|
🥳 |
|
🚀 PR was released in |
What Changed
Adds a Docker publish plugin.
Why
Simplifies publishing docker images with semver tags.
TODO:
I think most everything is done, possibly tests could be improved.