-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ssh support for connecting to github #1590
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
+ Coverage 81.19% 81.20% +0.01%
==========================================
Files 60 60
Lines 4461 4464 +3
Branches 1003 955 -48
==========================================
+ Hits 3622 3625 +3
Misses 577 577
Partials 262 262
Continue to review full report at Codecov.
|
@tinytim84 can you test with the new canary version? |
@tinytim84 Have you tested this? is this good to merge? |
@hipstersmoothie I got pulled onto something else and then had a few days off, but I'm back looking at this again now. I think it needs one more change before it's ready to merge. I'll hoping to have it ready by Monday. |
The canary release was successful, so this change is ready to go if you're happy with it. |
Awesome! |
There's still a slight issue that I'm working on now. I think I may have removed something I shouldn't have. |
Thanks for all your work and testing on this! |
🚀 PR was released in |
What Changed
Added support for SSH when connecting to github.
Why
It gives another route to connect to github that doesn't rely on personal access token
Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
📦 Published PR as canary version:
under canary scope @[email protected]
✨ Test out this PR locally via: