Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run various hooks in a --dry-run #1604

Merged
merged 8 commits into from
Oct 26, 2020
Merged

Run various hooks in a --dry-run #1604

merged 8 commits into from
Oct 26, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Oct 26, 2020

Release Notes

Previously a lot of the hooks would not run during a dry run and auto would try to guess what they would do. This lead to the output versions of some commands to be off.

With the release of v10 auto will call to the plugins for various hooks so they can control that.

Why

closes #1600
closes #1490
closes #1279

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @[email protected]

✨ Test out this PR locally via:

npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
# or 
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

@hipstersmoothie hipstersmoothie added the major Increment the major version when merged label Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1604 into next will decrease coverage by 0.58%.
The diff coverage is 77.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1604      +/-   ##
==========================================
- Coverage   80.95%   80.36%   -0.59%     
==========================================
  Files          54       60       +6     
  Lines        3948     4609     +661     
  Branches      809      996     +187     
==========================================
+ Hits         3196     3704     +508     
- Misses        540      624      +84     
- Partials      212      281      +69     
Impacted Files Coverage Δ
packages/bot-list/src/index.ts 0.00% <ø> (ø)
packages/cli/src/bin/auto.ts 17.64% <0.00%> (ø)
packages/cli/src/parse-args.ts 97.29% <ø> (ø)
packages/core/src/match-sha-to-pr.ts 93.10% <ø> (ø)
packages/core/src/utils/get-lerna-packages.ts 33.33% <0.00%> (ø)
packages/core/src/utils/load-plugins.ts 81.18% <ø> (ø)
packages/core/src/utils/logger.ts 70.00% <ø> (ø)
packages/core/src/utils/make-hooks.ts 100.00% <ø> (ø)
plugins/gradle/src/index.ts 70.51% <ø> (-5.49%) ⬇️
plugins/maven/src/index.ts 84.34% <ø> (-1.55%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9aa70d...e2d4f11. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 7ffc7df into next Oct 26, 2020
@hipstersmoothie hipstersmoothie deleted the dry-run-hooks branch October 26, 2020 23:21
@adierkens adierkens added the prerelease This change is available in a prerelease. label Oct 26, 2020
@adierkens adierkens mentioned this pull request Oct 26, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.0.0 🚀

@adierkens adierkens added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants