-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run various hooks in a --dry-run #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canary tests
hipstersmoothie
force-pushed
the
dry-run-hooks
branch
from
October 26, 2020 23:05
1b5ce77
to
e2d4f11
Compare
Codecov Report
@@ Coverage Diff @@
## next #1604 +/- ##
==========================================
- Coverage 80.95% 80.36% -0.59%
==========================================
Files 54 60 +6
Lines 3948 4609 +661
Branches 809 996 +187
==========================================
+ Hits 3196 3704 +508
- Misses 540 624 +84
- Partials 212 281 +69
Continue to review full report at Codecov.
|
Merged
🚀 PR was released in |
adierkens
added
released
This issue/pull request has been released.
and removed
prerelease
This change is available in a prerelease.
labels
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Previously a lot of the hooks would not run during a dry run and
auto
would try to guess what they would do. This lead to the output versions of some commands to be off.With the release of v10
auto
will call to the plugins for various hooks so they can control that.Why
closes #1600
closes #1490
closes #1279
Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
📦 Published PR as canary version:
under canary scope @[email protected]
✨ Test out this PR locally via: