Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make version, afterVersion, publish, and afterPublish series hooks #1620

Merged
merged 1 commit into from
Oct 30, 2020
Merged

make version, afterVersion, publish, and afterPublish series hooks #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/auto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export interface IAutoHooks {
]
>;
/** Version the package. This is a good opportunity to `git tag` the release also. */
version: AsyncParallelHook<
version: AsyncSeriesHook<
[
DryRunOption &
QuietOption & {
Expand All @@ -238,9 +238,9 @@ export interface IAutoHooks {
]
>;
/** Ran after the package has been versioned. */
afterVersion: AsyncParallelHook<[DryRunOption]>;
afterVersion: AsyncSeriesHook<[DryRunOption]>;
/** Publish the package to some package distributor. You must push the tags to github! */
publish: AsyncParallelHook<
publish: AsyncSeriesHook<
[
{
/** The semver bump that was applied in the version hook */
Expand Down Expand Up @@ -279,7 +279,7 @@ export interface IAutoHooks {
*/
next: AsyncSeriesWaterfallHook<[string[], NextContext]>;
/** Ran after the package has been published. */
afterPublish: AsyncParallelHook<[]>;
afterPublish: AsyncSeriesHook<[]>;
/** Ran after the package has been published. */
prCheck: AsyncSeriesHook<
[
Expand Down
8 changes: 4 additions & 4 deletions packages/core/src/utils/make-hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ export const makeHooks = (): IAutoHooks => ({
getPreviousVersion: new AsyncSeriesBailHook(),
getRepository: new AsyncSeriesBailHook(),
prCheck: new AsyncSeriesBailHook(["prInformation"]),
version: new AsyncParallelHook(["version"]),
afterVersion: new AsyncParallelHook(["context"]),
publish: new AsyncParallelHook(["version"]),
afterPublish: new AsyncParallelHook(),
version: new AsyncSeriesHook(["version"]),
afterVersion: new AsyncSeriesHook(["context"]),
publish: new AsyncSeriesHook(["version"]),
afterPublish: new AsyncSeriesHook(),
canary: new AsyncSeriesBailHook(["canaryContext"]),
next: new AsyncSeriesWaterfallHook(["preReleaseVersions", "context"]),
});
Expand Down