Feature/msteams #1914

vincentbriglia · 2021-03-25T17:24:20Z

What Changed

to

Why

@mentions are not supported for teams through the API: https://microsoftteams.uservoice.com/forums/555103-public/suggestions/17153099-webhook-needs-to-support-forced-notification-a-la
Teams now has crude markdown support, as long as the markdown is json escaped
Added a potential action with the URL of the changeset for people to click on it, instead of the string interpolation example.

Todo:

Add tests
Add docs
Fix the URL's generated for independently versioned packages

Change Type

Indicate the type of change your pull request is:

documentation
patch
minor
major

Note: I added you @hipstersmoothie to a teams channel as a guest, so you can try this out. I have also forwarded you the webhook URL

🐤 Download canary assets:

auto-linux--canary.1914.24254.gz
auto-macos--canary.1914.24254.gz
auto-win.exe--canary.1914.24254.gz

📦 Published PR as canary version: under canary scope @[email protected]

✨ Test out this PR locally via:

npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
npm install @auto-canary/[email protected]
# or 
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

icrosoft Teams accepts markdown, as long as the content was escaped/serialized to a JSON string first

Mentions don't actually work when posted through the teams/office api

instead of baking in the URL at the top

vincentbriglia · 2021-03-25T20:03:38Z

@hipstersmoothie question about the format for the response, to write tests for a release with multiple versions and packages, what is the response?

would the mockresponse look something like this?:

const mockResponse = [
  {
    data: {
      html_url: "https://git.hub/some/project/releases/v1.0.0",
      name: "v1.0.0",
    },
  },
  {
    data: {
      html_url: "https://git.hub/some/project/releases/v2.0.0",
      name: "v2.0.0",
    },
  },
];

hipstersmoothie · 2021-03-25T22:34:31Z

Probably more like:

const mockResponse = [
  {
    data: {
      html_url: "https://git.hub/some/project/releases/[email protected]",
      name: "[email protected]",
    },
  },
  {
    data: {
      html_url: "https://git.hub/some/project/releases/[email protected]",
      name: "[email protected]",
    },
  },
];

MS Teams might add this functionality later

vincentbriglia · 2021-03-26T17:10:46Z

right, so - teams doens't support the atTarget functionality and based on the tests and some of the responses i'm getting, i'm getting conflicting results for the markdown returned. I will try this out with the canary version

codecov · 2021-03-26T17:16:52Z

Codecov Report

Merging #1914 (5fa091a) into main (5d33773) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
- Coverage   80.17%   80.16%   -0.01%     
==========================================
  Files          66       66              
  Lines        5386     5375      -11     
  Branches     1252     1248       -4     
==========================================
- Hits         4318     4309       -9     
+ Misses        708      707       -1     
+ Partials      360      359       -1

Impacted Files	Coverage Δ
packages/core/src/log-parse.ts	`100.00% <ø> (ø)`
packages/core/src/git.ts	`87.53% <33.33%> (-0.25%)`	⬇️
plugins/microsoft-teams/src/index.ts	`85.96% <100.00%> (+1.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6b041...5fa091a. Read the comment docs.

vincentbriglia · 2021-03-26T17:38:39Z

The url's generated f.ex
https://github.com/LEGO/klik/releases/tag/%40lego/klik-ui-popover%400.5.3|@lego/[email protected]
don't work,

comparing, ofcourse does
https://github.com/LEGO/klik/compare/@lego/[email protected]...@lego/[email protected]

but i don't really know how to get that created here.

hipstersmoothie · 2021-03-26T21:41:53Z

It looks like the code for creating a list of slack formated links is still in there. I think you'd need to create an addon for each release

vincentbriglia · 2021-04-01T13:14:33Z

just not sure how to get the "previous release" in the context of multiple independently versioned packages. I know it comes from auto, newVersion in the afterRelease hook, I will need some help here.

reintroducing · 2021-05-06T14:35:11Z

@vincentbriglia this is fantastic, thank you!

@hipstersmoothie @adierkens what needs to be done to get this merged? I know @vincentbriglia said something about independently versioned packages, but it looks like he has made the applicable formatting changes for what was already in the Teams plugin thus far, and this is a huge improvement over whats currently being spit out by the Teams plugin, so can we at least get this merged to fix that portion?

hipstersmoothie · 2021-05-08T00:52:12Z

Fix the merge conflict and I'll merge ASAP!

reintroducing · 2021-05-08T02:29:16Z

@vincentbriglia Mind fixing the merge conflict and updating the PR?

vincentbriglia · 2021-05-08T12:32:26Z

@hipstersmoothie please check the last couple commits, I've fixed it - had some Tapable issues - I am using Yarn, fixed it by installing the external type declarations for Tapable

reintroducing · 2021-05-11T22:41:13Z

@hipstersmoothie Any chance you can take a look at this?

hipstersmoothie · 2021-05-11T22:56:55Z

Sorry I started a new job and have been super busy! Not to mention I also started a podcast 😅 I will for sure look at this this weekend. But if someone can find a way to make the tests pass before then I'll review and merge.

reintroducing · 2021-05-19T15:48:36Z

@hipstersmoothie understood, so you're no longer at Intuit? and actively working on auto?

all that to say, any updates on this? :)

hipstersmoothie · 2021-05-21T20:30:57Z

Yeah no longer at intuit but still an avid user of auto thought! Working at a startup constrains my time in much different ways though. @vincentbriglia I've fixed the issue, can you give me push access to your fork?

vincentbriglia · 2021-05-21T21:07:10Z

@hipstersmoothie done

reintroducing · 2021-05-22T13:57:42Z

@vincentbriglia @hipstersmoothie thanks guys, much appreciated!

@hipstersmoothie if you recall our convo about a screenshot of the Slack output added to the documentation (which you've already done), maybe you can use the above image to do the same for the Teams docs page to show how the output will look?

reintroducing · 2021-05-23T14:57:38Z

@vincentbriglia @hipstersmoothie hmm, i just ran this and this was the output:

hipstersmoothie · 2021-05-26T00:31:25Z

Once we fix the output we can do that ;P Any idea on the fix for that?

reintroducing · 2021-05-26T14:29:14Z

Not sure what happened with the output. @vincentbriglia have you tried this yet? How did you get the original output in your screenshot?

vincentbriglia · 2021-05-26T14:38:40Z

i haven't tried it, i will try it out tomorrow - am on a different product atm :)

vincentbriglia added 5 commits March 25, 2021 18:18

Remove githubtoslack and use simple json serialization instead

291afb5

icrosoft Teams accepts markdown, as long as the content was escaped/serialized to a JSON string first

remove default "channel" as it gets checked further down below.

e26123f

Mentions don't actually work when posted through the teams/office api

add an action button for people to click on

c636e95

instead of baking in the URL at the top

add @types/jsesc

302383f

correct import

ecccebd

adierkens added the minor Increment the minor version when merged label Mar 25, 2021

fix snaps

8f20c0b

Update snapshots as well as commenting out atTarget test

3db3145

MS Teams might add this functionality later

vincentbriglia mentioned this pull request May 6, 2021

Microsoft Teams plugin bugs #1961

Closed

vincentbriglia added 3 commits May 8, 2021 14:03

Merge branch 'main' into feature/msteams

cab90ec

chore: clamp rehype

1e2301e

fix: tapable issues

9877b9a

Merge branch 'main' into feature/msteams

e53e94a

fix tests

5fa091a

hipstersmoothie merged commit 1049d7c into intuit:main May 21, 2021

hipstersmoothie deleted the feature/msteams branch May 26, 2021 00:30

redrathnure mentioned this pull request Jun 22, 2021

Microsoft Teams - Invalid Message Formatting #2020

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/msteams #1914

Feature/msteams #1914

vincentbriglia commented Mar 25, 2021 •

edited by adierkens

Loading

vincentbriglia commented Mar 25, 2021

hipstersmoothie commented Mar 25, 2021

vincentbriglia commented Mar 26, 2021

codecov bot commented Mar 26, 2021 •

edited

Loading

vincentbriglia commented Mar 26, 2021

hipstersmoothie commented Mar 26, 2021

vincentbriglia commented Apr 1, 2021

reintroducing commented May 6, 2021

hipstersmoothie commented May 8, 2021

reintroducing commented May 8, 2021

vincentbriglia commented May 8, 2021

reintroducing commented May 11, 2021

hipstersmoothie commented May 11, 2021

reintroducing commented May 19, 2021

hipstersmoothie commented May 21, 2021

vincentbriglia commented May 21, 2021

reintroducing commented May 22, 2021

reintroducing commented May 23, 2021

hipstersmoothie commented May 26, 2021

reintroducing commented May 26, 2021

vincentbriglia commented May 26, 2021

Feature/msteams #1914

Feature/msteams #1914

Conversation

vincentbriglia commented Mar 25, 2021 • edited by adierkens Loading

What Changed

Why

Change Type

vincentbriglia commented Mar 25, 2021

hipstersmoothie commented Mar 25, 2021

vincentbriglia commented Mar 26, 2021

codecov bot commented Mar 26, 2021 • edited Loading

Codecov Report

vincentbriglia commented Mar 26, 2021

hipstersmoothie commented Mar 26, 2021

vincentbriglia commented Apr 1, 2021

reintroducing commented May 6, 2021

hipstersmoothie commented May 8, 2021

reintroducing commented May 8, 2021

vincentbriglia commented May 8, 2021

reintroducing commented May 11, 2021

hipstersmoothie commented May 11, 2021

reintroducing commented May 19, 2021

hipstersmoothie commented May 21, 2021

vincentbriglia commented May 21, 2021

reintroducing commented May 22, 2021

reintroducing commented May 23, 2021

hipstersmoothie commented May 26, 2021

reintroducing commented May 26, 2021

vincentbriglia commented May 26, 2021

vincentbriglia commented Mar 25, 2021 •

edited by adierkens

Loading

codecov bot commented Mar 26, 2021 •

edited

Loading