Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow load npm module as extends #2164

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Mar 7, 2022

What Changed

Allow to load npm module as config extends (not only based on package.json)

Why

This allow to build opinionated shared configuration published under npm module.
Would also mean that this config can load plugins regarding the context (as already possible with a local file reference)

Today this is possible by referencing ./node_module/my-shared-auto-config-module

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@intuit-svc intuit-svc added the minor Increment the minor version when merged label Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #2164 (1149233) into main (53a8de8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.01%     
==========================================
  Files          66       66              
  Lines        5420     5425       +5     
  Branches     1269     1271       +2     
==========================================
+ Hits         4353     4358       +5     
  Misses        707      707              
  Partials      360      360              
Impacted Files Coverage Δ
packages/core/src/config.ts 90.00% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd6684...1149233. Read the comment docs.

@jBouyoud jBouyoud marked this pull request as ready for review March 7, 2022 16:32
@jBouyoud
Copy link
Contributor Author

@hipstersmoothie Anything that I can do help merge this PR ?

@hipstersmoothie hipstersmoothie merged commit 34d4450 into intuit:main Mar 20, 2022
@intuit-svc
Copy link

🚀 PR was released in v10.36.0 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Mar 20, 2022
@jBouyoud jBouyoud deleted the auto-extends-module branch March 21, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants