Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release creation on oldVersions #2391

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jBouyoud
Copy link
Contributor

What Changed

Create a non latest release when working on oldVersions

Why

GH Api behavior do not handle the latest flag implicitly based on semver. We have to pass it explicitly

Ref : https://docs.github.com/en/free-pro-team@latest/rest/releases/releases?apiVersion=2022-11-28#create-a-release

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2391 (b08c1fe) into main (beeb948) will decrease coverage by 0.07%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   80.63%   80.57%   -0.07%     
==========================================
  Files          69       69              
  Lines        5670     5672       +2     
  Branches     1272     1274       +2     
==========================================
- Hits         4572     4570       -2     
- Misses        718      719       +1     
- Partials      380      383       +3     
Files Changed Coverage Δ
packages/core/src/auto.ts 77.94% <100.00%> (+0.02%) ⬆️
packages/core/src/git.ts 87.08% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@hipstersmoothie hipstersmoothie merged commit b351c58 into intuit:main Sep 6, 2023
6 of 9 checks passed
@github-actions
Copy link

🚀 PR was released in v11.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants