-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Allow opting out of ts-node #2420
[Feature Request] Allow opting out of ts-node #2420
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
- Coverage 85.92% 80.58% -5.34%
==========================================
Files 69 69
Lines 5675 5676 +1
Branches 1332 1275 -57
==========================================
- Hits 4876 4574 -302
- Misses 718 719 +1
- Partials 81 383 +302 ☔ View full report in Codecov by Sentry. |
@ds300 could you add a reference to this in the docs? |
@hipstersmoothie happy to. I don't see a convenient place to mention it, can you point me in the right direction? |
So looking at the docs we don't list global options anywhere 💀 Gonna have to fix that In the meantime: The only way to use this option right now would be by using auto programmatically which you probably don't want. We should add this ass a global CLI option too.
|
On the contrary! The only reason we need this option is because we are using auto programatically (is this kosher?). I don't think it would be an issue for anybody running auto on the cli. |
Oh wow I didn't even realize it was you lol Totally kosher to use pragmatically like that. Given you reasoning that seems fine to me! |
🚀 PR was released in |
What Changed
I added an option to prevent auto from installing the ts-node require hook.
Why
We recently upgraded
typescript
to v5 and one of our deploy scripts that used theAuto
class (as opposed to theauto
cli) started failing with the following error:This is most likely a problem with
ts-node
, since it seems to be passing an incorrect config to the ts compiler when transpiling modules. But also we already usetsx
for running this particular script, so we don't even need thets-node
hook to be registered. I'd appreciate if there was a semi-official way we could opt out of ts-node when using Auto as an api rather than a cli tool, hence this PR.Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major