Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use process.stderr stream for warn and error logs #2466

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

r0binary
Copy link

WHY

  • improves error handling because regular output and warning / errors are separated

What Changed

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

**WHY**
- improves error handling because regular output and warning / errors are separated
@r0binary
Copy link
Author

Not sure logging is considered part of the API here. If it isn't then it's surely not a breaking change.

@r0binary
Copy link
Author

Some background: What we're looking for is a way to separate logging output from the regular output (auto version in our case). We see log.warn messages on stdout in case of Github API rate limiting, but eventually the proper version gets printed.

This probably changes behavior for many users in a breaking way. So another option is to make the log stream configurable. User could then choose between Stdio or even a file. This is just a proposal (and it misses tests, because it's meant as a discussion starter only at this point). Happy to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant