Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isequal rather than == in a couple conditions #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented May 31, 2022

Avoid potential non-boolean type errors on missings.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #74 (53b7879) into main (eb33c8c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files           9        9           
  Lines         290      290           
=======================================
  Hits          281      281           
  Misses          9        9           
Impacted Files Coverage Δ
src/patterns.jl 100.00% <ø> (ø)
src/dataset.jl 93.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb33c8c...53b7879. Read the comment docs.

Copy link
Member

@glennmoy glennmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do with a small test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants