Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run ci against node 18.x, 20.x #1527

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

Jameskmonger
Copy link
Member

fixes #1526

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #1527 (b7ce5d1) into master (d26aa41) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #1527   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          53       53           
  Lines        1567     1567           
  Branches      205      205           
=======================================
  Hits         1561     1561           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@PodaruDragos PodaruDragos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just leave 18 and 20 ?
16 is EOL. so no point in including 16

@Jameskmonger
Copy link
Member Author

@PodaruDragos happy to do so if you think that's best, I left it in because of how recently EOL for 16.x was.

@Jameskmonger Jameskmonger changed the title ci: run ci against node 16.x, 18.x, 20.x ci: run ci against node 18.x, 20.x Sep 13, 2023
@Jameskmonger Jameskmonger changed the title ci: run ci against node 18.x, 20.x ci: run ci against node 18.x, 20.x Sep 13, 2023
@PodaruDragos PodaruDragos merged commit ed254b1 into master Sep 13, 2023
10 checks passed
@PodaruDragos PodaruDragos deleted the Jameskmonger-patch-1 branch September 13, 2023 19:19
Jameskmonger added a commit to inversify/inversify-express-utils that referenced this pull request Oct 25, 2023
Jameskmonger added a commit to inversify/inversify-express-utils that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for #549 are flaky (node 10 / es6)
3 participants