-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run ci against node 18.x, 20.x
#1527
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 53 53
Lines 1567 1567
Branches 205 205
=======================================
Hits 1561 1561
Partials 6 6 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just leave 18 and 20 ?
16 is EOL. so no point in including 16
@PodaruDragos happy to do so if you think that's best, I left it in because of how recently EOL for 16.x was. |
16.x, 18.x, 20.x
18.x, 20.x
18.x, 20.x
18.x, 20.x
fixes #1526