-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore hidden projects #272
base: main
Are you sure you want to change the base?
Conversation
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
@@ -424,6 +424,11 @@ Iterable<String> _findRoots(String path) sync* { | |||
final directory = Directory(path); | |||
|
|||
yield* directory.listSync(recursive: true).whereType<File>().where((file) { | |||
final relativePathSegments = split(relative(file.path)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct fix is to remove this and the isChildFromCache
logic and always return packageConfig.existsSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We'd need a test though :)
Do we still need a test for this? Is there an existing test I can modify? |
We always need tests :) You can modify the one that was added in the previous attempt at fixing this issue: 773b7ef |
@rrousselGit I updated the test and double checked that it fails without the fix |
@rrousselGit can we get this merged? |
I'll fix the CI tomorrow. We'll then see if this PR doesn't cause any regression |
Fixes #271