docs(ios): - Improve Remote Notification Support section #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunatiqueCoder
changed the title
mikehardy
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Lots of little nitpicks here and there but in general I really like this
Do you think you can incorporate these suggestions? A lot of them may be incorporated directly but some of them need to be manually added as they move things around just a little bit I think
Thank you!
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
|
|
||
| <br> | ||
|
|
||
| Before moving to the next step, run the app and check it builds successfully – make sure you have the correct target selected. |
There was a problem hiding this comment.
I also like this suggestion here again - so they do a build test once before they try to do custom code, and now they do another build test after trying to make custom code but before moving on
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
docs-react-native/react-native/docs/ios/remote-notification-support.md
Outdated
Show resolved
Hide resolved
|
Niiice. I resolved those ones that I just mostly copy pasted from you. Feel free to unresolve or come with other comments/suggestions. :) |
Henrryxdjr
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
A little revamp on the docs, added what tricks helped me, also mentioned what issued I ran into, etc etc.
Here are some main changes:
You can see the new README here:
https://github.com/LunatiqueCoder/notifee/blob/patch-1/docs-react-native/react-native/docs/ios/remote-notification-support.md
Hope you'll like it
Cheers 🍻