-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios, android): add FLUID size support #556
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 43.66% 43.72% +0.06%
==========================================
Files 29 30 +1
Lines 536 549 +13
Branches 147 151 +4
==========================================
+ Hits 234 240 +6
- Misses 302 309 +7 |
When using |
I find it quite useful especially for fluid ads which don't necessarily have their proper size set once loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite a chunk of work, thank. you! It all looks reasonable to me
🎉 This PR is included in version 13.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Support for FLUID size on Android and fix for iOS FLUID size.
I've built onto this PR to make sure we didn't have to set a fixed height to the ads.
We set "width: 100%" and the ads are responsible for setting their own height
Easier to check the whole changes as a whole with whitespace hidden (https://github.com/invertase/react-native-google-mobile-ads/pull/556/files?diff=split&w=1)
Related issues
Android: FLUID size wasn't supported yet on Android. Fixes #120
iOS: FLUID size was taking full device width. Fixes #213
Supercedes / Closes #277
Release Summary
feat: add FLUID size support
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
I've used the example app to test my changes (as well as a client app with actual production banners)
I've also checked the other banners on Android, since they're affected by this change
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter🔥