fix(banner, ios): fixed memory leak #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks for the investigation and PR. |
dylancom
reviewed
Apr 26, 2024
| _banner.paidEventHandler = ^(GADAdValue *_Nonnull value) { | ||
| [self sendEvent:@"onPaid" | ||
| [weakSelf sendEvent:@"onPaid" |
There was a problem hiding this comment.
The weak reference should be unwrapped. To avoid crashes if self could have been deallocated by the time the block executes.
There was a problem hiding this comment.
__weak typeof(self) weakSelf = self;
_banner.paidEventHandler = ^(GADAdValue *_Nonnull value) {
typeof(self) strongSelf = weakSelf;
if (strongSelf) {
[strongSelf sendEvent:@"onPaid"
payload:@{
@"value" : value.value,
@"precision" : @(value.precision),
@"currency" : value.currencyCode,
}];
}
};
dylancom
requested changes
Apr 26, 2024
| _banner.paidEventHandler = ^(GADAdValue *_Nonnull value) { | ||
| [self sendEvent:@"onPaid" | ||
| [weakSelf sendEvent:@"onPaid" |
There was a problem hiding this comment.
__weak typeof(self) weakSelf = self;
_banner.paidEventHandler = ^(GADAdValue *_Nonnull value) {
typeof(self) strongSelf = weakSelf;
if (strongSelf) {
[strongSelf sendEvent:@"onPaid"
payload:@{
@"value" : value.value,
@"precision" : @(value.precision),
@"currency" : value.currencyCode,
}];
}
};
|
🎉 This PR is included in version 13.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
#496
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter